Discussion:
Issue 505445 in chromium: Rename avatar_url to icon_url in the credential manager
(too old to reply)
c***@googlecode.com
2015-06-29 15:42:11 UTC
Permalink
Raw Message
Status: Started
Owner: ***@chromium.org
Labels: Type-Bug Pri-2 Cr-Blink OS-All

New issue 505445 by ***@chromium.org: Rename avatar_url to icon_url in
the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

1. In Blink
2. In CredentialInfo
3. In PasswordForm
4. In the PasswordStore backends
5. In the sync protobufs
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-06-29 15:44:11 UTC
Permalink
Raw Message
Comment #2 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

Part of the Blink change has already landed as
https://codereview.chromium.org/1209953002/, listed under the bug 494880.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-06-30 14:34:26 UTC
Permalink
Raw Message
Comment #3 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445#c3

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/cde556e2bc6d5095b864e626083a4a37cc1180e5

commit cde556e2bc6d5095b864e626083a4a37cc1180e5
Author: msramek <***@chromium.org>
Date: Tue Jun 30 13:44:17 2015

Rename avatar to icon in the credential manager in Chromium.

As specified in
https://w3c.github.io/webappsec/specs/credentialmanagement/#credential

The corresponding field in PasswordForm is still named avatar_url, to avoid
extensive changes in the backends.

This CL is a part of the three-sided patchset:
1. https://codereview.chromium.org/1209953002/
2. https://codereview.chromium.org/1209363003/ <-- this patch
3. https://codereview.chromium.org/1208193003/

BUG=505445

Review URL: https://codereview.chromium.org/1209363003

Cr-Commit-Position: refs/heads/master@{#336774}

[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/autofill/core/common/password_form.h
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/content/common/credential_manager_content_utils.cc
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/content/common/credential_manager_messages.h
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/content/renderer/credential_manager_client.cc
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/core/common/credential_manager_types.cc
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/core/common/credential_manager_types.h
[modify]
http://crrev.com/cde556e2bc6d5095b864e626083a4a37cc1180e5/components/password_manager/core/common/credential_manager_types_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-07-23 16:15:07 UTC
Permalink
Raw Message
Comment #5 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/5a74892971ce9c5577c55608fbf3a73ce308768e

commit 5a74892971ce9c5577c55608fbf3a73ce308768e
Author: msramek <***@chromium.org>
Date: Thu Jul 23 15:05:04 2015

Rename avatar_url to icon_url in PasswordForm.

As specified in
https://w3c.github.io/webappsec/specs/credentialmanagement/#credential

Do not rename it in the password store backends and sync yet:
- native_backend_gnome_x: string_attr_map["avatar_url"]
- native_backend_kwallet_x: {no names, just order}
- native_backend_libsecret:
secret_password_store_sync(..., "avatar_url", ...)
- login_database: "CREATE TABLE ... avatar_url ..."
- password_syncable_service: password_specifics->set_avatar_url(...)

These changes will be done in follow-up CLs.

BASE=1209953002
BUG=505445

Review URL: https://codereview.chromium.org/1220713005

Cr-Commit-Position: refs/heads/master@{#340096}

[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_gnome_x.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_kwallet_x.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_libsecret.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/password_store_mac_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/android/infobars/account_chooser_infobar.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/credential_item_view.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller_unittest.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/autofill/core/common/password_form.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/autofill/core/common/password_form.h
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/login_database.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/login_database_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_manager_test_utils.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_manager_test_utils.h
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_syncable_service.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/common/credential_manager_types.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/common/credential_manager_types_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-09-07 07:11:18 UTC
Permalink
Raw Message
Comment #6 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

Is this done, Martin? I think there are still some followup CLs, right?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-09-07 07:13:18 UTC
Permalink
Raw Message
Issue 505445: Rename avatar_url to icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

This issue is now blocking issue chromium:400674.
See https://code.google.com/p/chromium/issues/detail?id=400674

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-09-07 08:29:18 UTC
Permalink
Raw Message
Comment #8 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

The web-facing part is done, but the internal renaming is not. The border
is currently between PasswordForm and its backends (DBs, Sync). I can look
into it later today.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-09-10 10:59:31 UTC
Permalink
Raw Message
Comment #9 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/541ea2c1a1aae04a88bda5dcee3e10cf19d00399

commit 541ea2c1a1aae04a88bda5dcee3e10cf19d00399
Author: msramek <***@chromium.org>
Date: Thu Sep 10 10:51:11 2015

Rename avatar_url to icon_url in LoginDatabase.

BUG=505445

Review URL: https://codereview.chromium.org/1328743006

Cr-Commit-Position: refs/heads/master@{#348132}

[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/password_manager/core/browser/login_database.cc
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/password_manager/core/browser/login_database_unittest.cc
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v10.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v11.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v12.sql
[add]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v13.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v7.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v8.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v9.sql
[modify]
http://crrev.com/541ea2c1a1aae04a88bda5dcee3e10cf19d00399/components/test/data/password_manager/login_db_v9_without_use_additional_auth_field.sql
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 10:22:53 UTC
Permalink
Raw Message
Updates:
Status: Fixed

Comment #10 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...