Discussion:
Issue 383125 in chromium: Implement Geofencing API
(too old to reply)
c***@googlecode.com
2014-07-14 13:46:23 UTC
Permalink
Raw Message
Updates:
Cc: ***@chromium.org ***@chromium.org

Comment #1 on issue 383125 by ***@chromium.org: Implement Geofencing API
http://code.google.com/p/chromium/issues/detail?id=383125

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-14 14:05:32 UTC
Permalink
Raw Message
Comment #2 on issue 383125 by ***@chromium.org: Implement Geofencing
API
http://code.google.com/p/chromium/issues/detail?id=383125#c2

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=178052

------------------------------------------------------------------
r178052 | ***@chromium.org | 2014-07-14T12:58:48.886625Z

Changed paths:
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.idl?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.idl?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/GeofencingRegion.idl?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented-expected.txt?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.cpp?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-properties-geolocation-expected.txt?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.cpp?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.h?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.h?r1=178052&r2=178051&pathrev=178052
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/GeofencingRegion.h?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-dedicated-worker-expected.txt?r1=178052&r2=178051&pathrev=178052
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-shared-worker-expected.txt?r1=178052&r2=178051&pathrev=178052

Add the first very basic bits of a geofencing API.

Just adding the various methods on navigator.geolocation, which currently
all always fail.

BUG=383125

Review URL: https://codereview.chromium.org/375353002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-08-07 01:18:59 UTC
Permalink
Raw Message
Comment #3 on issue 383125 by ***@chromium.org: Implement Geofencing
API
http://code.google.com/p/chromium/issues/detail?id=383125#c3

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=179669

------------------------------------------------------------------
r179669 | ***@chromium.org | 2014-08-07T01:02:04.008400Z

Changed paths:
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.idl?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/GeofencingRegion.idl?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/CircularRegion.idl?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingRegion.idl?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented-expected.txt?r1=179669&r2=179668&pathrev=179669
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.cpp?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.cpp?r1=179669&r2=179668&pathrev=179669
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-properties-geolocation-expected.txt?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.idl?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/geofencing?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.cpp?r1=179669&r2=179668&pathrev=179669
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.h?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/CircularRegion.cpp?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.h?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/GeofencingRegion.h?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/CircularRegion.h?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/CircularRegion.h?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingRegion.h?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/geofencing/geofencing-not-implemented.html?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.cpp?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.h?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/geofencing/geofencing-not-implemented-expected.txt?r1=179669&r2=179668&pathrev=179669
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geolocation/Geolocation.idl?r1=179669&r2=179668&pathrev=179669
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Geolocation/geofencing-not-implemented.html?r1=179669&r2=179668&pathrev=179669
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=179669&r2=179668&pathrev=179669
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.idl?r1=179669&r2=179668&pathrev=179669

Move all geofencing code into its own module separate from geolocation.

BUG=383125

Review URL: https://codereview.chromium.org/401713005
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-02 21:11:44 UTC
Permalink
Raw Message
Comment #6 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d

commit 5741bc85329c968d4590ceba67148b1dced8621d
Author: mek <***@chromium.org>
Date: Thu Oct 02 20:38:22 2014

Pass through geofencing API calls to the browser process.

BUG=383125

Review URL: https://codereview.chromium.org/476293002

Cr-Commit-Position: refs/heads/master@{#297892}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/browser/DEPS
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/browser/geofencing/geofencing_dispatcher_host.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/browser/geofencing/geofencing_dispatcher_host.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/browser/renderer_host/render_process_host_impl.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/blink_platform_impl.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/blink_platform_impl.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/child_thread.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/child_thread.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/geofencing_dispatcher.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/geofencing_dispatcher.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/geofencing_message_filter.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/geofencing_message_filter.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/web_geofencing_provider_impl.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/child/geofencing/web_geofencing_provider_impl.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/common/DEPS
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/common/content_message_generator.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/common/geofencing_messages.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/common/geofencing_status.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/common/geofencing_status.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/content_browser.gypi
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/content_child.gypi
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/content/content_common.gypi
[modify]
https://chromium.googlesource.com/chromium/src.git/+/5741bc85329c968d4590ceba67148b1dced8621d/ipc/ipc_message_start.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-08 20:47:47 UTC
Permalink
Raw Message
Comment #7 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c7

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=183426

------------------------------------------------------------------
r183426 | ***@chromium.org | 2014-10-08T19:41:15.072890Z

Changed paths:
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/ServiceWorkerGlobalScopeGeofencing.h?r1=183426&r2=183425&pathrev=183426
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/ServiceWorkerGlobalScopeGeofencing.idl?r1=183426&r2=183425&pathrev=183426
A
http://src.chromium.org/viewvc/blink/trunk/public/platform/WebGeofencingEventType.h?r1=183426&r2=183425&pathrev=183426
M
http://src.chromium.org/viewvc/blink/trunk/public/web/WebServiceWorkerContextProxy.h?r1=183426&r2=183425&pathrev=183426
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.cpp?r1=183426&r2=183425&pathrev=183426
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeProxy.cpp?r1=183426&r2=183425&pathrev=183426
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=183426&r2=183425&pathrev=183426
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/events/EventTypeNames.in?r1=183426&r2=183425&pathrev=183426
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.h?r1=183426&r2=183425&pathrev=183426
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.idl?r1=183426&r2=183425&pathrev=183426
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/ServiceWorkerGlobalScopeProxy.h?r1=183426&r2=183425&pathrev=183426

Blink side of geofencing event dispatching in service workers.

BUG=383125

Review URL: https://codereview.chromium.org/624343002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-09 07:00:55 UTC
Permalink
Raw Message
Comment #8 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c8

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=183442

------------------------------------------------------------------
r183442 | ***@opera.com | 2014-10-09T06:41:12.778302Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.cpp?r1=183442&r2=183441&pathrev=183442
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/GeofencingEvent.h?r1=183442&r2=183441&pathrev=183442

Oilpan: fix build after r183426.

TBR=haraken,oilpan-reviews
BUG=383125
NOTRY=true

Review URL: https://codereview.chromium.org/639133002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-17 00:15:25 UTC
Permalink
Raw Message
Updates:
Cc: ***@chromium.org ***@chromium.org ***@chromium.org
***@chromium.org ***@chromium.org
Labels: Cr-Internals-GPU-Testing Build-CommitQueue

Comment #12 on issue 383125 by ***@chromium.org: Implement Geofencing API
https://code.google.com/p/chromium/issues/detail?id=383125

https://codereview.chromium.org/645763003 caused the browser to hang upon
exit on Windows and sent the Windows GPU tryserver into a loop -- buildbot
would repeatedly retry the run, taking one slave offline permanently. Here
are a couple of such jobs:

One that I killed:

http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64497
http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64483
http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64472
http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64455
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-17 00:23:25 UTC
Permalink
Raw Message
Updates:
Cc: -***@chromium.org -***@chromium.org -***@chromium.org
-***@chromium.org -***@chromium.org
Labels: -Cr-Internals-GPU-Testing -Build-CommitQueue

Comment #13 on issue 383125 by ***@chromium.org: Implement Geofencing API
https://code.google.com/p/chromium/issues/detail?id=383125

I assume adding those labels to this bug was a mistake? There are already
two other bugs about the tryserver problems. Hijacking this bug doesn't
seem like it would make sense.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-17 23:28:15 UTC
Permalink
Raw Message
Comment #14 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c14

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=183931

------------------------------------------------------------------
r183931 | ***@chromium.org | 2014-10-17T22:31:13.246399Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerRegistration.h?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.cpp?r1=183931&r2=183930&pathrev=183931
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/resources/emptyworker.js?r1=183931&r2=183930&pathrev=183931
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.idl?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/public/platform/WebGeofencingProvider.h?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.h?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/WorkerNavigatorGeofencing.cpp?r1=183931&r2=183930&pathrev=183931
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.cpp?r1=183931&r2=183930&pathrev=183931
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/geofencing/geofencing-not-implemented.html?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/WorkerNavigatorGeofencing.h?r1=183931&r2=183930&pathrev=183931
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.h?r1=183931&r2=183930&pathrev=183931
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.cpp?r1=183931&r2=183930&pathrev=183931
D
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/NavigatorGeofencing.h?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=183931&r2=183930&pathrev=183931
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/apis_not_implemented.html?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/modules.gypi?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp?r1=183931&r2=183930&pathrev=183931
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/WorkerNavigatorGeofencing.idl?r1=183931&r2=183930&pathrev=183931
A
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.idl?r1=183931&r2=183930&pathrev=183931

Blink side of exposing the service worker registration associated with
geofencing API calls.
This still leaves the old codepaths for the geofencing API in place, those
will be cleaned up in a followup CL.

BUG=383125

Review URL: https://codereview.chromium.org/623813002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-23 22:22:53 UTC
Permalink
Raw Message
Comment #15 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c15

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22

commit 0c55c7f631795d3f76b38bc7f6b54f5be7da8f22
Author: mek <***@chromium.org>
Date: Thu Oct 23 22:06:09 2014

Refactor GeofencingManager to have one instance per StoragePartition.

Add a new GeofencingService class for the few global tasks GeofencingManager
used to do.

BUG=383125

Review URL: https://codereview.chromium.org/645763003

Cr-Commit-Position: refs/heads/master@{#300960}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_dispatcher_host.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_dispatcher_host.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_manager.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_manager.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_manager_unittest.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_provider.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_registration_delegate.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_service.cc
[add]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_service.h
[add]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/geofencing/geofencing_service_unittest.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/renderer_host/render_process_host_impl.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/storage_partition_impl.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/browser/storage_partition_impl.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/content_browser.gypi
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/content_tests.gypi
[modify]
https://chromium.googlesource.com/chromium/src.git/+/0c55c7f631795d3f76b38bc7f6b54f5be7da8f22/content/public/browser/storage_partition.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-14 16:53:53 UTC
Permalink
Raw Message
Comment #10 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c10

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/8aa4301e8669ec1bc9b60e39532552bbb7261d03

commit 8aa4301e8669ec1bc9b60e39532552bbb7261d03
Author: mek <***@chromium.org>
Date: Tue Oct 14 16:25:44 2014

Make myself owner of the geofencing code.

BUG=383125

Review URL: https://codereview.chromium.org/647633003

Cr-Commit-Position: refs/heads/master@{#299491}

[add]
https://chromium.googlesource.com/chromium/src.git/+/8aa4301e8669ec1bc9b60e39532552bbb7261d03/content/browser/geofencing/OWNERS
[add]
https://chromium.googlesource.com/chromium/src.git/+/8aa4301e8669ec1bc9b60e39532552bbb7261d03/content/child/geofencing/OWNERS
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-24 05:37:07 UTC
Permalink
Raw Message
Comment #17 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c17

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/3e26604a0beccb0469cbdc0886b9822f0a5d175d

commit 3e26604a0beccb0469cbdc0886b9822f0a5d175d
Author: mek <***@chromium.org>
Date: Fri Oct 24 05:35:11 2014

Fix uninitialized memory introduced in
https://codereview.chromium.org/623823002/

BUG=383125
TBR=michaeln

Review URL: https://codereview.chromium.org/676963002

Cr-Commit-Position: refs/heads/master@{#301059}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/3e26604a0beccb0469cbdc0886b9822f0a5d175d/content/common/service_worker/service_worker_types.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-24 18:47:09 UTC
Permalink
Raw Message
Comment #18 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c18

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=184375

------------------------------------------------------------------
r184375 | ***@chromium.org | 2014-10-24T17:52:11.221789Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/public/platform/WebGeofencingProvider.h?r1=184375&r2=184374&pathrev=184375
M
http://src.chromium.org/viewvc/blink/trunk/Source/modules/geofencing/Geofencing.cpp?r1=184375&r2=184374&pathrev=184375

Cleanup after http://crrev.com/623813002/ now the chrome side has landed.

BUG=383125

Review URL: https://codereview.chromium.org/680503004
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-10-29 23:04:07 UTC
Permalink
Raw Message
Comment #19 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c19

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c

commit 1c397381ff0444275cbc932eb750c86888f5669c
Author: mek <***@chromium.org>
Date: Wed Oct 29 23:01:55 2014

Chromium side of geofencing event dispatching.

BUG=383125

Review URL: https://codereview.chromium.org/629393002

Cr-Commit-Position: refs/heads/master@{#301965}

[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/DEPS
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/geofencing/geofencing_manager.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/geofencing/geofencing_manager.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/geofencing/geofencing_registration_delegate.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/geofencing/geofencing_service_unittest.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/service_worker/service_worker_version.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/browser/service_worker/service_worker_version.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/common/DEPS
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/common/service_worker/service_worker_messages.h
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/renderer/service_worker/service_worker_script_context.cc
[modify]
https://chromium.googlesource.com/chromium/src.git/+/1c397381ff0444275cbc932eb750c86888f5669c/content/renderer/service_worker/service_worker_script_context.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-12-11 08:33:31 UTC
Permalink
Raw Message
Comment #22 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c22

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=186927

------------------------------------------------------------------
r186927 | ***@chromium.org | 2014-12-11T08:25:19.911706Z

Changed paths:
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/resources/worker-service-not-available.js?r1=186927&r2=186926&pathrev=186927
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/resources/worker-passes-events-back.js?r1=186927&r2=186926&pathrev=186927
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/service-worker.html?r1=186927&r2=186926&pathrev=186927
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/resources/worker.js?r1=186927&r2=186926&pathrev=186927
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/service-not-available.html?r1=186927&r2=186926&pathrev=186927
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/apis_not_implemented.html?r1=186927&r2=186926&pathrev=186927
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/geofencing/event_triggering.html?r1=186927&r2=186926&pathrev=186927

Update geofencing layout tests to use mock service.

Depends on chromium side: https://codereview.chromium.org/701953007/

BUG=383125

Review URL: https://codereview.chromium.org/702983002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-10 00:50:43 UTC
Permalink
Raw Message
Comment #23 on issue 383125 by ***@chromium.org: Implement Geofencing
API
https://code.google.com/p/chromium/issues/detail?id=383125#c23

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/05b26f88e6d0a7559a050c12ae01cf00917bd0b2

commit 05b26f88e6d0a7559a050c12ae01cf00917bd0b2
Author: mek <***@chromium.org>
Date: Sat Jan 10 00:09:59 2015

Cleanup geofence registrations when a service worker is unregistered.

This changes ServiceWorkerContextObserver::OnRegistrationDeleted to include
the
registration ID.
Also modify GeofencingManager unit tests to have an actual
ServiceWorkerContextWrapper instance to test this behavior.

BUG=444136,383125

Review URL: https://codereview.chromium.org/788073007

Cr-Commit-Position: refs/heads/master@{#310905}

[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/geofencing/geofencing_manager.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/geofencing/geofencing_manager.h
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/geofencing/geofencing_manager_unittest.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_context_core.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_context_core.h
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_context_observer.h
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_context_unittest.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_internals_ui.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_job_unittest.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_unregister_job.cc
[modify]
http://crrev.com/05b26f88e6d0a7559a050c12ae01cf00917bd0b2/content/browser/service_worker/service_worker_unregister_job.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 10:03:03 UTC
Permalink
Raw Message
Comment #25 on issue 383125 by ***@chromium.org: Implement
Geofencing API
https://code.google.com/p/chromium/issues/detail?id=383125

Issue 587248 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...