Discussion:
Issue 565765 in chromium: [META] WTF cleanups under Blink Onion Soup context
(too old to reply)
c***@googlecode.com
2015-12-04 05:44:28 UTC
Permalink
Raw Message
Status: Assigned
Owner: ***@chromium.org
Labels: Type-Bug Pri-2 Cr-Blink OS-All Hotlist-CodeHealth

New issue 565765 by ***@chromium.org: [META] WTF cleanups under Blink
Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765

An umbrella bug that hosts individual issues around WTF and Onion Soup.

See also:
https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/Q33LLqPQO2A/MFUueW-cCwAJ
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-12-08 09:23:56 UTC
Permalink
Raw Message
Updates:
Blockedon: chromium:565932

Comment #3 on issue 565765 by ***@chromium.org: [META] WTF cleanups under
Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-12-10 08:23:25 UTC
Permalink
Raw Message
Comment #4 on issue 565765 by ***@chromium.org: [META] WTF cleanups under
Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765

I've drilled down to almost all headers in WTF and gathered my thoughts in
the
following spreadsheet:

https://docs.google.com/spreadsheets/d/1-OyE2MgypFI5B-GfqFGRLgPtpa_aBaFC_uyh9rdIq3g/edit?usp=sharing

I'm going to discuss this in architecture team before actually starting to
work on
these.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-12-14 20:04:22 UTC
Permalink
Raw Message
Comment #5 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/75af515a0347cc0c10a3685f1eafed1d7479a1f2

commit 75af515a0347cc0c10a3685f1eafed1d7479a1f2
Author: esprehn <***@chromium.org>
Date: Mon Dec 14 19:59:36 2015

Remove WTF::alias in favor of base::debug::Alias.

We can just use base::debug::Alias and get rid of ours, it's literally copy
paste.

I also fixed the missing dep for base in wtf.gyp, we added dependencies on
base
from WTF in StringUTF8Adapter, but since that header is only actually used
in
platform things compiled, but in reality we forgot to update our build deps.

BUG=565765

Review URL: https://codereview.chromium.org/1517913002

Cr-Commit-Position: refs/heads/master@{#365078}

[delete]
http://crrev.com/f593336f972fa8d64584baf5c2e5cef809857a88/third_party/WebKit/Source/wtf/Alias.cpp
[delete]
http://crrev.com/f593336f972fa8d64584baf5c2e5cef809857a88/third_party/WebKit/Source/wtf/Alias.h
[modify]
http://crrev.com/75af515a0347cc0c10a3685f1eafed1d7479a1f2/third_party/WebKit/Source/wtf/DEPS
[modify]
http://crrev.com/75af515a0347cc0c10a3685f1eafed1d7479a1f2/third_party/WebKit/Source/wtf/Partitions.cpp
[modify]
http://crrev.com/75af515a0347cc0c10a3685f1eafed1d7479a1f2/third_party/WebKit/Source/wtf/wtf.gyp
[modify]
http://crrev.com/75af515a0347cc0c10a3685f1eafed1d7479a1f2/third_party/WebKit/Source/wtf/wtf.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-12 05:19:36 UTC
Permalink
Raw Message
Comment #7 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9

commit bddd6cc1556651ce5f3a02615f2fface3dc7f4e9
Author: yutak <***@chromium.org>
Date: Tue Jan 12 05:16:54 2016

Blink Platform: Remove cryptographicallyRandomValues().

WTF now can depend on base, so the plumbing for dependency
injection (calling via a function pointer) is no longer necessary. We
just need to call base::RandBytes() directly.

The functionality of returning '\0' bytes for unit tests is rewritten
and now resides in CryptographicallyRandomNumber.cpp.

BUG=565765
R=***@chromium.org, ***@chromium.org

Review URL: https://codereview.chromium.org/1535733004

Cr-Commit-Position: refs/heads/master@{#368802}

[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/components/html_viewer/blink_platform_impl.cc
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/components/html_viewer/blink_platform_impl.h
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/components/test_runner/test_common.cc
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/content/child/blink_platform_impl.cc
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/content/child/blink_platform_impl.h
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/media/blink/run_all_unittests.cc
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/web/WebKit.cpp
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.cpp
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.h
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/wtf/DEPS
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/Source/wtf/testing/RunAllTests.cpp
[modify]
http://crrev.com/bddd6cc1556651ce5f3a02615f2fface3dc7f4e9/third_party/WebKit/public/platform/Platform.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-29 06:41:16 UTC
Permalink
Raw Message
Updates:
Blockedon: chromium:581524

Comment #8 on issue 565765 by ***@chromium.org: [META] WTF cleanups under
Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-09 06:11:51 UTC
Permalink
Raw Message
Comment #9 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2

commit 2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2
Author: yutak <***@chromium.org>
Date: Tue Feb 09 05:55:05 2016

WTF::bind: Remove the need of hand-rolled code for bound arguments.

This patch adds a generalized version of PartBoundFunctionImpl for
WTF::bind(), and removes the hand-rolled code that contains the
repetition for cases with zero to seven bound arguments.

The key trick is to use std::tuple<T...> to pass the types of bound
parameters.

This patch adds a new dependency to base/tuple.h for a simple utility
called base::IndexSequence defined there. The bind code lives in WTF, so
this should be fine.

BUG=565765

Review URL: https://codereview.chromium.org/1679773002

Cr-Commit-Position: refs/heads/master@{#374319}

[modify]
http://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2/third_party/WebKit/Source/wtf/DEPS
[modify]
http://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2/third_party/WebKit/Source/wtf/Functional.h
[modify]
http://crrev.com/2a02e48ea74b0608a2eb43aa935a3cd7dbaea8f2/third_party/WebKit/Source/wtf/FunctionalTest.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-16 07:01:31 UTC
Permalink
Raw Message
Comment #10 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c10

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/a5466f457a195abd0f03066439c0efae3b5e14b0

commit a5466f457a195abd0f03066439c0efae3b5e14b0
Author: yutak <***@chromium.org>
Date: Tue Feb 16 06:58:50 2016

Blink Platform: Remove time functions from Platform.

Simplification!

To support the use case of mocking timers for tests, CurrentTime.h now
provides a customization function. Currently, it overrides the three
functions at once, but practically that wouldn't be a problem.

Some unit tests try to override timing functions by replacing
Platform. However, CachingCorrectnessTest and TextFinderTest seemed to
fail to do so, as they apparently lacked Platform::initialize()
calls. I'm not sure why these tests have not been failing. Anyways, this
patch "fixes" these issues, too.

BUG=565765

Review URL: https://codereview.chromium.org/1550563002

Cr-Commit-Position: refs/heads/master@{#375524}

[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/content/child/blink_platform_impl.cc
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/content/child/blink_platform_impl.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/Timer.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/TimerTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/SafePoint.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/web/WebKit.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/CurrentTime.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/CurrentTime.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/DEPS
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/WTF.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/WTF.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/testing/RunAllTests.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/public/platform/Platform.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-17 06:09:28 UTC
Permalink
Raw Message
Comment #11 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/24c03a3a0e5b1dcd133fd43d31774091e9291f64

commit 24c03a3a0e5b1dcd133fd43d31774091e9291f64
Author: yutak <***@chromium.org>
Date: Wed Feb 17 05:43:51 2016

Move some CrossThreadCopierBase specializations to CrossThreadCopier.

This patch is an attempt to simplify CrossThreadCopier(Base) template
specializations. It changes some specializations of CrossThreadCopierBase
to CrossThreadCopier's specializations, so we don't have to write three
booleans for each specific specialization.

This patch should not change the behavior.

BUG=565765

Review URL: https://codereview.chromium.org/1700713002

Cr-Commit-Position: refs/heads/master@{#375800}

[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/core/css/MediaValuesCached.h
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/core/dom/DocumentEncodingData.h
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/core/fetch/ResourceLoaderOptions.h
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/core/loader/ThreadableLoader.h
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/platform/CrossThreadCopier.cpp
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/platform/CrossThreadCopier.h
[modify]
http://crrev.com/24c03a3a0e5b1dcd133fd43d31774091e9291f64/third_party/WebKit/Source/platform/network/ResourceTimingInfo.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 09:46:46 UTC
Permalink
Raw Message
Comment #12 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/e17b74910a29f7db108c177670a9c0f15556ed33

commit e17b74910a29f7db108c177670a9c0f15556ed33
Author: yutak <***@chromium.org>
Date: Thu Feb 18 09:43:39 2016

CrossThreadCopier: Consider arithmetic and enum types as safe.

The original code assumed that types convertible to int were safe to
copy cross-thread. However, this condition is too narrow; any
arithmetic types (integers and floats) and enum types are actually
safe. This is fixed by this patch.

Additionally, this patch rearranges the order of CrossThreadCopierBase's
template parameters, because putting T in the last looks unusual. Also,
the specializations of CrossThreadCopierBase are updated so that the
readers can understand the specializations cover all the possible
combinations of template parameters (except for <T, false, false,
false>, which is intentionally undefined in the header).

BUG=565765
R=***@chromium.org, ***@chromium.org, ***@chromium.org

Review URL: https://codereview.chromium.org/1701013003

Cr-Commit-Position: refs/heads/master@{#376129}

[modify]
http://crrev.com/e17b74910a29f7db108c177670a9c0f15556ed33/third_party/WebKit/Source/platform/CrossThreadCopier.cpp
[modify]
http://crrev.com/e17b74910a29f7db108c177670a9c0f15556ed33/third_party/WebKit/Source/platform/CrossThreadCopier.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...