Discussion:
Issue 550922 in chromium: Account chooser UI on desktop
(too old to reply)
c***@googlecode.com
2015-11-03 12:49:58 UTC
Permalink
Raw Message
Status: Assigned
Owner: ***@chromium.org
Labels: Type-Bug Pri-2 Cr-UI-Browser-Passwords OS-Mac OS-Windows OS-Linux

New issue 550922 by ***@chromium.org: Account chooser UI on desktop
https://code.google.com/p/chromium/issues/detail?id=550922

The account chooser UI should be a modal dialog.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-18 14:40:25 UTC
Permalink
Raw Message
Comment #5 on issue 550922 by ***@chromium.org: Account chooser UI on
desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/f68983f1af84b16ba7dafeb4b41666eac37782d8

commit f68983f1af84b16ba7dafeb4b41666eac37782d8
Author: vasilii <***@chromium.org>
Date: Mon Jan 18 14:38:25 2016

Show the account chooser as a dialog on Aura.

BUG=550922

Review URL: https://codereview.chromium.org/1583113006

Cr-Commit-Position: refs/heads/master@{#370023}

[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/account_chooser_prompt.h
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/manage_passwords_test.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/manage_passwords_test.h
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/password_dialog_controller.h
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/password_dialog_controller_impl.h
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
[rename]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[rename]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
[add]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
[modify]
http://crrev.com/f68983f1af84b16ba7dafeb4b41666eac37782d8/chrome/chrome_tests.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-21 14:30:31 UTC
Permalink
Raw Message
Comment #7 on issue 550922 by ***@chromium.org: Account chooser UI on
desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/26173e3e8ab8da1050ee7260dac3d2be714ad5f8

commit 26173e3e8ab8da1050ee7260dac3d2be714ad5f8
Author: vasilii <***@chromium.org>
Date: Thu Jan 21 14:03:30 2016

Integrate the account chooser dialog on Mac.

BUG=550922

Review URL: https://codereview.chromium.org/1610653002

Cr-Commit-Position: refs/heads/master@{#370691}

[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/app/generated_resources.grd
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[add]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.h
[add]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm
[delete]
http://crrev.com/39deaa00ffa9ebe186c5a81dc889883fc49e6c97/chrome/browser/ui/passwords/account_chooser_more_combobox_model.cc
[delete]
http://crrev.com/39deaa00ffa9ebe186c5a81dc889883fc49e6c97/chrome/browser/ui/passwords/account_chooser_more_combobox_model.h
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/browser/ui/passwords/password_dialog_controller_impl.cc
[modify]
http://crrev.com/26173e3e8ab8da1050ee7260dac3d2be714ad5f8/chrome/chrome_browser_ui.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-22 14:16:32 UTC
Permalink
Raw Message
Comment #8 on issue 550922 by ***@chromium.org: Account chooser UI on
desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c8

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/af68b7127d2994a870059d351a0fd07ad866bcd9

commit af68b7127d2994a870059d351a0fd07ad866bcd9
Author: vasilii <***@chromium.org>
Date: Fri Jan 22 14:13:40 2016

Remove the account chooser bubble and autosignin warm welcome.

Mark the obsolete histogram values. This reverts
https://codereview.chromium.org/1417753005.

BUG=550922

Review URL: https://codereview.chromium.org/1611673002

Cr-Commit-Position: refs/heads/master@{#370959}

[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/views/passwords/credentials_item_view.h
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/components/password_manager/core/browser/password_manager_metrics_util.h
[modify]
http://crrev.com/af68b7127d2994a870059d351a0fd07ad866bcd9/tools/metrics/histograms/histograms.xml
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-08 15:08:27 UTC
Permalink
Raw Message
Comment #9 on issue 550922 by ***@chromium.org: Account chooser UI on
desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/3a012dada0c5718f05658808476c648b4012f8ec

commit 3a012dada0c5718f05658808476c648b4012f8ec
Author: vasilii <***@chromium.org>
Date: Mon Feb 08 15:06:30 2016

Fix a crash when choosing a credential from the account chooser.

The crash happened because ManagePasswordsUIController::ChooseCredential()
used a reference to the member of PasswordDialogControllerImpl after
destructing the dialog controller.

BUG=550922

Review URL: https://codereview.chromium.org/1675253002

Cr-Commit-Position: refs/heads/master@{#374123}

[modify]
http://crrev.com/3a012dada0c5718f05658808476c648b4012f8ec/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify]
http://crrev.com/3a012dada0c5718f05658808476c648b4012f8ec/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify]
http://crrev.com/3a012dada0c5718f05658808476c648b4012f8ec/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h
[modify]
http://crrev.com/3a012dada0c5718f05658808476c648b4012f8ec/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify]
http://crrev.com/3a012dada0c5718f05658808476c648b4012f8ec/chrome/browser/ui/passwords/passwords_model_delegate.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-16 10:12:33 UTC
Permalink
Raw Message
Comment #10 on issue 550922 by ***@chromium.org: Account chooser UI on
desktop
https://code.google.com/p/chromium/issues/detail?id=550922

Mac

Attachments:
Screen Shot 2016-02-15 at 15.56.35.png 22.2 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-16 14:46:47 UTC
Permalink
Raw Message
Comment #11 on issue 550922 by ***@chromium.org: Account chooser UI
on desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/5594447e3e6d024bc3f7db983b94557d33206ca4

commit 5594447e3e6d024bc3f7db983b94557d33206ca4
Author: vasilii <***@chromium.org>
Date: Tue Feb 16 14:37:28 2016

Rewrite the account chooser on Mac to match the mocks.

BUG=550922

Review URL: https://codereview.chromium.org/1702583002

Cr-Commit-Position: refs/heads/master@{#375567}

[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/app/generated_resources.grd
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.h
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/account_avatar_fetcher_manager.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.h
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm
[add]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/credential_item_button.h
[add]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/credential_item_button.mm
[delete]
http://crrev.com/62b0e65dabfbfda4ea1ddbb37b3fb53a1007c464/chrome/browser/ui/cocoa/passwords/credential_item_view.h
[delete]
http://crrev.com/62b0e65dabfbfda4ea1ddbb37b3fb53a1007c464/chrome/browser/ui/cocoa/passwords/credential_item_view.mm
[delete]
http://crrev.com/62b0e65dabfbfda4ea1ddbb37b3fb53a1007c464/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/chrome_browser_ui.gypi
[modify]
http://crrev.com/5594447e3e6d024bc3f7db983b94557d33206ca4/chrome/chrome_tests_unit.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-17 10:32:26 UTC
Permalink
Raw Message
Comment #12 on issue 550922 by ***@chromium.org: Account chooser UI
on desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/f605897713cb554352d6e289565de33d51781288

commit f605897713cb554352d6e289565de33d51781288
Author: vasilii <***@chromium.org>
Date: Wed Feb 17 10:28:26 2016

Rename the title of the account chooser dialog.

BUG=550922

Review URL: https://codereview.chromium.org/1702733003

Cr-Commit-Position: refs/heads/master@{#375846}

[modify]
http://crrev.com/f605897713cb554352d6e289565de33d51781288/chrome/app/generated_resources.grd
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 09:49:46 UTC
Permalink
Raw Message
Comment #14 on issue 550922 by ***@chromium.org: Account chooser UI
on desktop
https://code.google.com/p/chromium/issues/detail?id=550922#c14

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/10284b9e09824f6e8ae5437808dbdbdc9cdabea4

commit 10284b9e09824f6e8ae5437808dbdbdc9cdabea4
Author: vasilii <***@chromium.org>
Date: Thu Feb 18 09:45:29 2016

Change the account chooser on Win to look like in the mocks.

BUG=550922

Review URL: https://codereview.chromium.org/1701363002

Cr-Commit-Position: refs/heads/master@{#376130}

[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/passwords/password_dialog_prompts.h
[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/views/passwords/credentials_item_view.h
[modify]
http://crrev.com/10284b9e09824f6e8ae5437808dbdbdc9cdabea4/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...