Comment #5 on issue 505445 by ***@chromium.org: Rename avatar_url to
icon_url in the credential manager
https://code.google.com/p/chromium/issues/detail?id=505445#c5
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/5a74892971ce9c5577c55608fbf3a73ce308768e
commit 5a74892971ce9c5577c55608fbf3a73ce308768e
Author: msramek <***@chromium.org>
Date: Thu Jul 23 15:05:04 2015
Rename avatar_url to icon_url in PasswordForm.
As specified in
https://w3c.github.io/webappsec/specs/credentialmanagement/#credential
Do not rename it in the password store backends and sync yet:
- native_backend_gnome_x: string_attr_map["avatar_url"]
- native_backend_kwallet_x: {no names, just order}
- native_backend_libsecret:
secret_password_store_sync(..., "avatar_url", ...)
- login_database: "CREATE TABLE ... avatar_url ..."
- password_syncable_service: password_specifics->set_avatar_url(...)
These changes will be done in follow-up CLs.
BASE=1209953002
BUG=505445
Review URL: https://codereview.chromium.org/1220713005
Cr-Commit-Position: refs/heads/master@{#340096}
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_gnome_x.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_kwallet_x.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_libsecret.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/password_manager/password_store_mac_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/android/infobars/account_chooser_infobar.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/credential_item_view.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/credential_item_view_unittest.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller_unittest.mm
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/autofill/core/common/password_form.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/autofill/core/common/password_form.h
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/login_database.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/login_database_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_manager_test_utils.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_manager_test_utils.h
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_syncable_service.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/common/credential_manager_types.cc
[modify]
http://crrev.com/5a74892971ce9c5577c55608fbf3a73ce308768e/components/password_manager/core/common/credential_manager_types_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.