Discussion:
Issue 389610 in chromium: Fix Default Network transition logic in NetworkStateHandler
(too old to reply)
c***@googlecode.com
2014-06-27 19:54:48 UTC
Permalink
Updates:
Summary: Fix Default Network transition logic in NetworkStateHandler

Comment #1 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-06-27 20:05:47 UTC
Permalink
Updates:
Labels: -Pri-2 Pri-1 ReleaseBlock-Beta

Comment #2 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610

Elevating to P1 because of the potential for this edge case to cause subtle
bugs.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-06-29 20:31:51 UTC
Permalink
Comment #3 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610#c3

------------------------------------------------------------------
r280550 | ***@chromium.org | 2014-06-29T20:29:44.618196Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/network/network_state_handler.cc?r1=280550&r2=280549&pathrev=280550

Fix Default Network transitions in NetworkStateHandler

BUG=389610

Review URL: https://codereview.chromium.org/358173002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-06-29 20:33:51 UTC
Permalink
Comment #4 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610#c4

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/791e6c0a178b4c0f23301a87c2902c16fe3dbd15

commit 791e6c0a178b4c0f23301a87c2902c16fe3dbd15
Author: ***@chromium.org
<***@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sun Jun 29 20:29:44 2014

Fix Default Network transitions in NetworkStateHandler

BUG=389610

Review URL: https://codereview.chromium.org/358173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/***@280550
0039d316-1c4b-4281-b951-d872f2087c98
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-06-30 18:35:21 UTC
Permalink
Updates:
Labels: Merge-Requested

Comment #7 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610

To verify this on ToT:

1. Test connecting / diconnecting networks, in particular between Ethernet
and WiFi.

Observe: There should be no "Default network is not connected" or "Active
network follows inactive network" error messages in the Network Event Log
(and network UI should behave as expected).
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-06-30 18:33:21 UTC
Permalink
Updates:
Labels: Merge-TBD

Comment #6 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610#c6

Is there a merge required here?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-10 02:18:35 UTC
Permalink
Updates:
Labels: -Merge-Approved merge-merged-2062

Comment #9 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/82f6cc421a8c6050dfd26a11909668c1a6bdd784

commit 82f6cc421a8c6050dfd26a11909668c1a6bdd784
Author: ***@chromium.org
<***@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jul 10 02:17:25 2014

Merge 280550 "Fix Default Network transitions in NetworkStateHan..."
Post by c***@googlecode.com
Fix Default Network transitions in NetworkStateHandler
BUG=389610
Review URL: https://codereview.chromium.org/358173002
TBR=***@chromium.org

Review URL: https://codereview.chromium.org/380963003

git-svn-id: svn://svn.chromium.org/chrome/branches/2062/***@282214
0039d316-1c4b-4281-b951-d872f2087c98
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-10 02:24:36 UTC
Permalink
Comment #10 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610#c10

------------------------------------------------------------------
r282214 | ***@chromium.org | 2014-07-10T02:17:25.141778Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/2062/src/chromeos/network/network_state_handler.cc?r1=282214&r2=282213&pathrev=282214

Merge 280550 "Fix Default Network transitions in NetworkStateHan..."
Post by c***@googlecode.com
Fix Default Network transitions in NetworkStateHandler
BUG=389610
Review URL: https://codereview.chromium.org/358173002
TBR=***@chromium.org

Review URL: https://codereview.chromium.org/380963003
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-18 01:37:29 UTC
Permalink
Updates:
Status: Verified

Comment #11 on issue 389610 by ***@chromium.org: Fix Default Network
transition logic in NetworkStateHandler
http://code.google.com/p/chromium/issues/detail?id=389610

Verified with 5978.22.0, R37.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...