Discussion:
Issue 450400 in chromium: [Freon] Messages are not displaying while switching between modes.
(too old to reply)
c***@googlecode.com
2015-01-21 00:02:27 UTC
Permalink
Status: Untriaged
Owner: ----
CC: ***@chromium.org, ***@chromium.org,
***@chromium.org, ***@chromium.org, ***@chromium.org
Labels: Type-Bug-Regression Pri-1 Cr-Internals-Installer OS-Chrome M-41
ReleaseBlock-Beta

New issue 450400 by ***@chromium.org: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Version: 6680.9.0
OS: Chromeo

What steps will reproduce the problem?
1. Install recovery image on a dev mode device.
2. Switch to normal mode
(Press space bar on dev screen)
3. Switch to dev mode
( Press Ctrl + d on recovery screen)

What is the expected output?
User should get proper messages while switching between modes.

What do you see instead?
Messages are not displaying while switching between modes.

Please use labels and text to provide additional information.
Facing this issue only with freon builds.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 00:07:27 UTC
Permalink
Updates:
Status: Assigned
Owner: ***@chromium.org
Labels: -Cr-Internals-Installer

Comment #1 on issue 450400 by ***@chromium.org: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

I believe Dharani to triage freon specific bugs.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 00:44:31 UTC
Permalink
Updates:
Owner: ***@chromium.org

Comment #2 on issue 450400 by ***@google.com: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Alex, could you triage this? thanks!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 03:14:42 UTC
Permalink
Updates:
Owner: ***@chromium.org
Cc: ***@chromium.org

Comment #3 on issue 450400 by ***@chromium.org: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

I think this is frecon that should be painting those, I don't believe
chrome is even started at this point.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 03:21:42 UTC
Permalink
Updates:
Cc: ***@chromium.org
Labels: freon

Comment #4 on issue 450400 by ***@chromium.org: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 03:22:42 UTC
Permalink
Comment #5 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Yes this is done without chrome. Pretty much a duplicate of
https://code.google.com/p/chrome-os-partner/issues/detail?id=33214
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-21 03:25:42 UTC
Permalink
Comment #6 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Issue chrome-os-partner:33214 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-01-27 17:32:41 UTC
Permalink
Comment #8 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

dsodman: any updates?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-02-10 03:54:39 UTC
Permalink
Updates:
Blockedon: chromium:457081

Comment #14 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-02-18 19:58:34 UTC
Permalink
Comment #15 on issue 450400 by ***@chromium.org: [Freon] Messages are not
displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

There is a message that is displayed when switching to dev mode. I would
have been happier if we specifically called it out that the device is not
hang and it is in fact working to switch. Right now, instead of the user
thinking the device is stuck at the Chrome Logo s/he will think the device
is stuck at the "new message screen".
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-02-19 23:56:27 UTC
Permalink
Updates:
Labels: -M-41 M-42

Comment #16 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Since we have workaround, moving this to M42.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-02-24 22:19:03 UTC
Permalink
Updates:
Labels: -M-42 M-43 Iteration-128

Comment #18 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-28 00:02:01 UTC
Permalink
Updates:
Labels: -ReleaseBlock-Stable

Comment #21 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Since we have a workaround, I'm removing the release blocker label.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-05 21:00:48 UTC
Permalink
Updates:
Labels: Iteration-133

Comment #30 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-05 21:02:48 UTC
Permalink
Comment #31 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Issue 431456 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-20 15:15:31 UTC
Permalink
Comment #32 on issue 450400 by ***@chromium.org: [Freon] Messages
are not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Issue chrome-os-partner:40425 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-21 03:57:52 UTC
Permalink
Updates:
Labels: merge-merged-master

Comment #33 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c33

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa

commit f0a925a7aeacdcfa77aaf0ed96ba32faff513faa
Author: David Sodman <***@chromium.org>
Date: Mon May 04 18:19:19 2015

Add terminal properties to splash screen

In order to support text display and input on the splash screen for
powerwash and dev/normal transitions, the splash screen needs to be
attached to a terminal. This change creates a terminal for the splash
screen and directs the name of the pts device to stdout so that
the scripts that launch the terminal can access the terminal.

BUG=chromium:450400
TEST=test on link with looping splash screen

Change-Id: I9ab746f67627a8258bf87920f3c462ef4341ff10
Reviewed-on: https://chromium-review.googlesource.com/269211
Reviewed-by: Haixia Shi <***@chromium.org>
Tested-by: David Sodman <***@chromium.org>
Commit-Queue: David Sodman <***@chromium.org>

[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/input.h
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/util.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/dbus.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/input.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/main.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/term.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/splash.h
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/splash.c
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/term.h
[modify] http://crrev.com/f0a925a7aeacdcfa77aaf0ed96ba32faff513faa/font.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-21 13:47:20 UTC
Permalink
Updates:
Labels: Merge-Approved-44

Comment #34 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Please merge it in M44. thanks!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-23 02:33:19 UTC
Permalink
Comment #38 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

I wasn't able to land dsodman@'s revert in
https://chromium-review.googlesource.com/272794, since it broke VMTests on
rambi-paladin, for some reason (see issue 491272).

So, I wrote a workaround for ungrabbing the input in
https://chromium-review.googlesource.com/273007.

Something else I've noticed while debugging it:
1. VM creates /dev/card1 a long time after frecon calls kms_open. This
currently leads to frecon crashing a couple of times during boot.
Much nicer to have
splash->video = video_init();
if (splash->video == NULL) {
free(splash);
return NULL;
}
2. Some code got duplicated in
https://chromium-review.googlesource.com/269211
I don't think we need to do
video_release(splash->video);
video_unlock(splash->video);

if (dbus != NULL && 0) {
do {
LOG(ERROR, "splash_run calling dbus_init 2");
*dbus = dbus_init();
usleep(DBUS_WAIT_DELAY);
} while (*dbus == NULL);
splash_set_dbus(splash, *dbus);
}
a second time inside "if (splash->devmode)". This also prints a "failed to
register object path" warning for the 2nd dbus_init() call.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-23 02:39:19 UTC
Permalink
Updates:
Cc: ***@chromium.org ***@chromium.org ***@chromium.org

Comment #39 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Issue 491415 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-23 04:35:20 UTC
Permalink
Comment #40 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Found out that rambi-paladin VMTest failure because of which I couldn't
revert the change in #33 was caused by the frecon crashes I've described in
#38.
Uploaded https://chromium-review.googlesource.com/273022, so that we won't
have VMTest flakiness.
No idea why did they pass before the change in #33 landed.

Also uploaded https://chromium-review.googlesource.com/273015 to fix the
second problem I've described in #38, while at it.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-23 05:23:44 UTC
Permalink
Comment #41 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c41

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/088ca0fff8e26c2b5f7361d2fef8581f068e2dd7

commit 088ca0fff8e26c2b5f7361d2fef8581f068e2dd7
Author: Yuly Novikov <***@chromium.org>
Date: Sat May 23 01:32:11 2015

Workaround for frecon not releasing input to chrome.

f0a925a7aeacdcfa77aaf0ed96ba32faff513faa
added term_activate() call in splash_run().
This grabs the input but never releases it.
I don't know where it's supposed to be released, so tentatively adding this
near "Now Chrome can take over" comment.

BUG=chromium:450400
TEST=boot veyron_jerry, able to move cursor and type in password

Change-Id: I04eae97d8cb3cfd65dc67e86252aae95f61f048c
Reviewed-on: https://chromium-review.googlesource.com/273007
Trybot-Ready: Yuly Novikov <***@chromium.org>
Reviewed-by: Stéphane Marchesin <***@chromium.org>
Commit-Queue: Yuly Novikov <***@chromium.org>
Tested-by: Yuly Novikov <***@chromium.org>

[modify] http://crrev.com/088ca0fff8e26c2b5f7361d2fef8581f068e2dd7/splash.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-23 06:46:30 UTC
Permalink
Comment #42 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c42

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/945871ec75b797c9c61e8ba4d65a580e0fee242f

commit 945871ec75b797c9c61e8ba4d65a580e0fee242f
Author: Yuly Novikov <***@chromium.org>
Date: Sat May 23 04:00:41 2015

Check video_init() result.

Since in VM /dev/dri/card1 may be created after frecon run,
kms_open(), and video_init() as the result will often fail.
This would lead to frecon crashes early in the boot, and VMTest failures.

BUG=chromium:450400,chromium:491272
TEST=boot rambi VM, observe no frecon segfaults in syslog

Change-Id: I2b2e766a99809db1356c0d7fdaaf850e8652fc84
Reviewed-on: https://chromium-review.googlesource.com/273022
Trybot-Ready: Yuly Novikov <***@chromium.org>
Reviewed-by: Stéphane Marchesin <***@chromium.org>
Commit-Queue: Yuly Novikov <***@chromium.org>
Tested-by: Yuly Novikov <***@chromium.org>

[modify] http://crrev.com/945871ec75b797c9c61e8ba4d65a580e0fee242f/splash.c
[modify] http://crrev.com/945871ec75b797c9c61e8ba4d65a580e0fee242f/main.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-26 01:04:58 UTC
Permalink
Comment #43 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c43

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/945871ec75b797c9c61e8ba4d65a580e0fee242f

commit 945871ec75b797c9c61e8ba4d65a580e0fee242f
Author: Yuly Novikov <***@chromium.org>
Date: Sat May 23 04:00:41 2015

Check video_init() result.

Since in VM /dev/dri/card1 may be created after frecon run,
kms_open(), and video_init() as the result will often fail.
This would lead to frecon crashes early in the boot, and VMTest failures.

BUG=chromium:450400,chromium:491272
TEST=boot rambi VM, observe no frecon segfaults in syslog

Change-Id: I2b2e766a99809db1356c0d7fdaaf850e8652fc84
Reviewed-on: https://chromium-review.googlesource.com/273022
Trybot-Ready: Yuly Novikov <***@chromium.org>
Reviewed-by: Stéphane Marchesin <***@chromium.org>
Commit-Queue: Yuly Novikov <***@chromium.org>
Tested-by: Yuly Novikov <***@chromium.org>

[modify] http://crrev.com/945871ec75b797c9c61e8ba4d65a580e0fee242f/splash.c
[modify] http://crrev.com/945871ec75b797c9c61e8ba4d65a580e0fee242f/main.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-05-26 21:20:16 UTC
Permalink
Comment #44 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c44

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/8114e8b24918e18fe45f57618513c689b722f30a

commit 8114e8b24918e18fe45f57618513c689b722f30a
Author: Yuly Novikov <***@chromium.org>
Date: Sat May 23 04:19:08 2015

Remove code duplication in splash_run.

Probably a result of copy-paste in f0a925a7aeacdcfa77aaf0ed96ba32faff513faa.

BUG=chromium:450400
TEST=No "frecon: failed to register object path" in syslog

Change-Id: I7fbdab6ada6aafe5b0eef1af7a682e7c1bdbdb54
Reviewed-on: https://chromium-review.googlesource.com/273015
Trybot-Ready: Yuly Novikov <***@chromium.org>
Reviewed-by: Stéphane Marchesin <***@chromium.org>
Commit-Queue: Yuly Novikov <***@chromium.org>
Tested-by: Yuly Novikov <***@chromium.org>

[modify] http://crrev.com/8114e8b24918e18fe45f57618513c689b722f30a/splash.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-06-10 22:50:08 UTC
Permalink
Updates:
Labels: merge-merged-release-R44-7077.B

Comment #45 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c45

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/39b37e5de8a68afda9c4b593f36e3f2562852df2

commit 39b37e5de8a68afda9c4b593f36e3f2562852df2
Author: David Sodman <***@chromium.org>
Date: Mon May 04 18:19:19 2015

Add terminal properties to splash screen

In order to support text display and input on the splash screen for
powerwash and dev/normal transitions, the splash screen needs to be
attached to a terminal. This change creates a terminal for the splash
screen and directs the name of the pts device to stdout so that
the scripts that launch the terminal can access the terminal.

BUG=chromium:450400
TEST=test on link with looping splash screen

Change-Id: I9ab746f67627a8258bf87920f3c462ef4341ff10
Previous-Reviewed-on: https://chromium-review.googlesource.com/269211
(cherry picked from commit 493c27ba2bc2b9e8f3cb807c4ab21ffac145b697)
Reviewed-on: https://chromium-review.googlesource.com/276734
Tested-by: David Sodman <***@chromium.org>
Reviewed-by: David Sodman <***@chromium.org>

[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/input.h
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/util.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/dbus.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/input.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/main.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/term.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/splash.h
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/splash.c
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/term.h
[modify] http://crrev.com/39b37e5de8a68afda9c4b593f36e3f2562852df2/font.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-06-10 23:09:10 UTC
Permalink
Comment #46 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400#c46

The following revision refers to this bug:

https://chromium.googlesource.com/chromiumos/platform/frecon/+/ba5115cc03b511601da5011fbecfabbfade7e2a4

commit ba5115cc03b511601da5011fbecfabbfade7e2a4
Author: Yuly Novikov <***@chromium.org>
Date: Sat May 23 01:32:11 2015

Workaround for frecon not releasing input to chrome.

f0a925a7aeacdcfa77aaf0ed96ba32faff513faa
added term_activate() call in splash_run().
This grabs the input but never releases it.
I don't know where it's supposed to be released, so tentatively adding this
near "Now Chrome can take over" comment.

BUG=chromium:450400
TEST=boot veyron_jerry, able to move cursor and type in password

Change-Id: I04eae97d8cb3cfd65dc67e86252aae95f61f048c
Previous-Reviewed-on: https://chromium-review.googlesource.com/273007
(cherry picked from commit de85395bc737c7d383063cc5a62bf58f0cae3351)
Reviewed-on: https://chromium-review.googlesource.com/276756
Reviewed-by: Yuly Novikov <***@chromium.org>
Tested-by: David Sodman <***@chromium.org>

[modify] http://crrev.com/ba5115cc03b511601da5011fbecfabbfade7e2a4/splash.c
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-06-10 23:22:10 UTC
Permalink
Comment #47 on issue 450400 by ***@chromium.org: [Freon] Messages are
not displaying while switching between modes.
https://code.google.com/p/chromium/issues/detail?id=450400

Would be great if we also merge
https://chromium-review.googlesource.com/#/c/265969/ into M44 - it's a
better solution for #43. Without it we might get some VMTest failures on
the bots.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Continue reading on narkive:
Loading...