Discussion:
Issue 276238 in chromium: Support undoing the deletion of a text hyperlink
(too old to reply)
c***@googlecode.com
2013-08-20 10:35:02 UTC
Permalink
Status: Untriaged
Owner: ----
Labels: Type-Bug Cr-Platform-Apps-Default-ChromeOffice-Word OS-Chrome

New issue 276238 by ***@chromium.org: Support undoing the deletion of
a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

The user should be able to delete text hyperlink content and have Undo
bring it back again. The undone content must save/round-trip correctly.

Implementation notes:
- need an addHyperlink Core command and its implementation in Core
- need to ensure we have sufficient qowt parent/sibling data to place the
re-added node. This (parentId) must account for 'qowt' nodes that are not
present in the Core Dom, such that the core command to addElement specifies
a parent that the Core knows about.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-08-27 11:30:45 UTC
Permalink
Updates:
Owner: ***@chromium.org

Comment #3 on issue 276238 by ***@chromium.org: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-09-23 11:22:46 UTC
Permalink
Updates:
Owner: ***@chromium.org

Comment #8 on issue 276238 by ***@chromium.org: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-09-23 19:23:12 UTC
Permalink
Updates:
Labels: -M-31 M-32

Comment #9 on issue 276238 by ***@chromium.org: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-09-26 14:18:40 UTC
Permalink
Comment #13 on issue 276238 by ***@chromium.org: Support undoing
the deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

CL up for review:
https://quickoffice-internal-review.googlesource.com/#/c/7122/
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-09-27 16:07:46 UTC
Permalink
Updates:
Status: Fixed

Comment #14 on issue 276238 by ***@chromium.org: Support undoing
the deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Issue fixed,

Has landed in master:
https://cheese-build.fra.corp.google.com/browse/CAN-EDIT-1414

Now support undo/redo of deletion of hyperlinks.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-11-11 13:43:08 UTC
Permalink
Updates:
Labels: edit hyperlinks undo pagination

Comment #20 on issue 276238 by ***@chromium.org: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-11-19 09:10:29 UTC
Permalink
Comment #23 on issue 276238 by ***@synerzip.com: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Verified on latest master build.

Build : quickoffice-chrome-0.0.0.1706
Platform : Chrome book X-86
Chrome Browser Version:32.0.1700.12 dev
OS: 4920.8.0 (Official Build) dev-channel lumpy

Test Observation-
Undoing the deletion of a text hyperlink works fine. However after RT, when
file is opened in MS Office,formatting style of hyperlink text is
lost.(Underlined & Blue colored text)For this, following crbug is already
opened.

https://code.google.com/p/chromium/issues/detail?id=315642
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-11-19 11:06:50 UTC
Permalink
Comment #24 on issue 276238 by ***@synerzip.com: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Verified this issue as "Undo_Redo Retest Exercise" on Debug Build.

Build : quickoffice-chrome-0.0.0.1706
Platform : Chrome book X-86
Chrome Browser Version:32.0.1700.12 dev
OS: 4920.8.0 (Official Build) dev-channel lumpy

Test Observation-
Undoing the deletion of a text hyperlink works fine. However after RT, when
file is opened in MS Office,formatting style of hyperlink text is
lost.(Underlined & Blue colored text)For this, following crbug is already
opened.

https://code.google.com/p/chromium/issues/detail?id=315642
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-12-09 12:18:31 UTC
Permalink
Comment #29 on issue 276238 by ***@synerzip.com: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Verified this issue as "Undo_Redo Retest Exercise" on Debug Build.

Build : QO build #1805
Platform : windows 8
chrome browser: Version 31.0.1650.63 m

Test Observation-
Using "Core-driven Undo/Redo", the Undo for < Deletion of text hyperlink >
works fine but Redo does not work.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-12-10 06:51:15 UTC
Permalink
Comment #30 on issue 276238 by ***@synerzip.com: Support undoing the
deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Verified with build #1814
Tested on :
1) Version 33.0.1712.3 dev
Platform 4982.0.0 (Official Build) dev-channel lumpy
Firmware Google_Lumpy.2.111.0
2) windows 8
crhome browser : Version 33.0.1733.2 canary

The Issue is reproducible :
1) refer to attached file/video(.swf file that can be played in chrome
browser)
2) It has two links
3) Delete second link>hit Undo>data restored>works fine
4) Hit Redo now>Nothing happens
5) Now Delete both links>Undo
6) Only one of the links are restored.


Attachments:
Hyperlink.docx 14.5 KB
276238.swf 563 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2013-12-16 06:50:44 UTC
Permalink
Updates:
Status: Verified

Comment #32 on issue 276238 by ***@synerzip.com: Support undoing
the deletion of a text hyperlink
http://code.google.com/p/chromium/issues/detail?id=276238

Issue not reproducible.
undo/redo of hyperlink deletion works . The problem I am experiencing is
that the cursor gets missing after performing the undo/redo action.

If you manually place the cursor you will see that the hyperlink gets
deleted/restored properly. As for the cursor issue, we already have a
separate crbug for that: 319216.

Platform used:
OS :chrome
browser version : 33.0.1734.6 dev
Platform 5085.4.0 (Official Build) dev-channel parrot
Firmware Google_Parrot.2685.37.0
Chrome office build : Chrome Office Viewer (Beta) 33.96.1843.5
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...