Discussion:
Re: Issue 543161 in chromium: Replace safe browsing DB and update protocol with Pver4
(too old to reply)
c***@googlecode.com
2015-10-22 22:54:22 UTC
Permalink
Comment #2 on issue 543161 by ***@chromium.org: Replace safe browsing
DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c2

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/1f66733b39fdc5499c034497a3747a97b5bcc0db

commit 1f66733b39fdc5499c034497a3747a97b5bcc0db
Author: dalecurtis <***@chromium.org>
Date: Thu Oct 22 22:38:35 2015

Revert of Move prefix_set and parts of s_b_util into a new component
safe_browsing_db. (patchset #7 id:120001 of
https://codereview.chromium.org/1399843003/ )

Reason for revert:
Broke the Windows x64 GN builders:

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN&number=7560
Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.
BUG=543161
Committed: https://crrev.com/607ee298239a88fa0823c3aea10bcee83eff855a
TBR=***@chromium.org,***@chromium.org,***@chromium.org,***@chromium.org,***@chromium.org,***@chromium.org,***@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161

Review URL: https://codereview.chromium.org/1420143002

Cr-Commit-Position: refs/heads/master@{#355659}

[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/BUILD.gn
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/DEPS
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/prefix_set.cc
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/prefix_set.h
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/prefix_set_unittest.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_store.h
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_util.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_util.h
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/chrome_browser.gypi
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/test/BUILD.gn
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/test/data/SafeBrowsing/PrefixSetRef
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/test/data/SafeBrowsing/PrefixSetVersion2
[rename]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/chrome/test/data/SafeBrowsing/PrefixSetVersion3
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/components/BUILD.gn
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/components/components.gyp
[modify]
http://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db/components/components_tests.gyp
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db.gypi
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/BUILD.gn
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/DEPS
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/OWNERS
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/README
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/safe_browsing_db_util.cc
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/safe_browsing_db_util.h
[delete]
http://crrev.com/3b277d12e535a5404178e488c0b79ebeb618aa6c/components/safe_browsing_db/safe_browsing_db_util_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-10-29 21:20:55 UTC
Permalink
Comment #3 on issue 543161 by ***@chromium.org: Replace safe browsing
DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c3

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd

commit 9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd
Author: vakh <***@google.com>
Date: Thu Oct 29 21:04:07 2015

[This CL = CL 1399843003 + disabling E4267 for MSVS (in
safe_browsing_db.gypi)]

Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.

BUG=543161

Review URL: https://codereview.chromium.org/1415923004

Cr-Commit-Position: refs/heads/master@{#356943}

[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/BUILD.gn
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/DEPS
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_store.h
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_util.cc
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_util.h
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/browser/safe_browsing/safe_browsing_util_unittest.cc
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/chrome_browser.gypi
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/chrome/test/BUILD.gn
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/BUILD.gn
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/components.gyp
[modify]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/components_tests.gyp
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db.gypi
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/BUILD.gn
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/DEPS
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/OWNERS
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/README
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/prefix_set.cc
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/prefix_set.h
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/prefix_set_unittest.cc
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/safe_browsing_db_util.cc
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/safe_browsing_db_util.h
[add]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/safe_browsing_db/safe_browsing_db_util_unittest.cc
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/test/data/SafeBrowsingDb/PrefixSetRef
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/test/data/SafeBrowsingDb/PrefixSetVersion2
[rename]
http://crrev.com/9d588802e87e1776c0e55f7c0e8b21dc5acbf1bd/components/test/data/SafeBrowsingDb/PrefixSetVersion3
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-11-05 23:36:02 UTC
Permalink
Comment #7 on issue 543161 by ***@chromium.org: Replace safe browsing
DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/d0a17ec746888e2ec643991c9a155920c2de2378

commit d0a17ec746888e2ec643991c9a155920c2de2378
Author: vakh <***@google.com>
Date: Thu Nov 05 23:14:34 2015

Move more declarations from c/b/sb/sb_util.h to components.

Attempt 2:
1. Pull all code unrelated to chunking from
chrome/browser/safe_browsing/safe_browsing_util.h
into components/safe_browsing_db.
2. All code that was formerly under the safe_browsing_util namespace is now
under safe_browsing.
That's the only namespace we plan to use going forward.
3. Chunking related code will stay in the old location and removed once we
switch to PVER4.

Attempt 1: https://codereview.chromium.org/1420123003/
Reverted as: https://codereview.chromium.org/1410343012/
Reason: There was a compile error on Win64Dbg with the following message:
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225):
warning
C4267: 'argument' : conversion from 'size_t' to 'int', possible
loss of data

Resolution: Updating the BUILD.gn file to ignore that warning for Windows.

BUG=543161

Review URL: https://codereview.chromium.org/1423033009

Cr-Commit-Position: refs/heads/master@{#358168}

[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/prerender/prerender_browsertest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/database_manager.h
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/local_database_manager.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/local_database_manager.h
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/protocol_manager.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/protocol_parser.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/protocol_parser_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_database.h
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_util.cc
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/browser/safe_browsing/safe_browsing_util.h
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/components_tests.gyp
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db.gypi
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/BUILD.gn
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/DEPS
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/prefix_set.h
[modify]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/prefix_set_unittest.cc
[add]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/util.cc
[add]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/util.h
[rename]
http://crrev.com/d0a17ec746888e2ec643991c9a155920c2de2378/components/safe_browsing_db/util_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-08 18:02:04 UTC
Permalink
Comment #11 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/6d6153fae158605e7926d8a6706a0f7e7ab50b32

commit 6d6153fae158605e7926d8a6706a0f7e7ab50b32
Author: droger <***@chromium.org>
Date: Fri Jan 08 17:46:22 2016

[iOS] Duplicate //components/safe_browsing_db/util

This is temporary code duplication to remove dependency
of iOS on safe_browsing_db.

BUG=543161
TBR=agl

Review URL: https://codereview.chromium.org/1571783002

Cr-Commit-Position: refs/heads/master@{#368366}

[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/chrome/chrome_browser.gypi
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/components/components.gyp
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/DEPS
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/hit_report.h
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/ping_manager.h
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/safe_browsing_service.h
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/ui_manager.h
[add]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/util.cc
[add]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/util.h
[add]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/browser/safe_browsing/util_unittest.cc
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/ios_chrome.gyp
[modify]
http://crrev.com/6d6153fae158605e7926d8a6706a0f7e7ab50b32/ios/chrome/ios_chrome_tests.gyp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-13 22:22:21 UTC
Permalink
Comment #12 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/76fc703b2570eb7fbde3174eefa5188e0e12f54b

commit 76fc703b2570eb7fbde3174eefa5188e0e12f54b
Author: Daniel Cheng <***@chromium.org>
Date: Wed Jan 13 22:04:45 2016

Move database_manager from c/b/safe_browsing to components/safe_browsing_db.

Also move hit_report into safe_browsing_db since db_manager depends on it.

BUG=543161
R=***@chromium.org, ***@chromium.org, ***@chromium.org,
***@chromium.org

Review URL: https://codereview.chromium.org/1566913002 .

Cr-Commit-Position: refs/heads/master@{#369269}

[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/extensions/blacklist.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/prerender/prerender_browsertest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/client_side_detection_host.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/download_protection_service.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/download_protection_service.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[delete]
http://crrev.com/e5c134116a97f8c6dfc580de2a3ae9d3d74a9dfd/chrome/browser/safe_browsing/hit_report.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/local_database_manager.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/ping_manager.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/remote_database_manager.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/safe_browsing_test.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/ui_manager.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/ui_manager.h
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/unverified_download_policy.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/browser/safe_browsing/unverified_download_policy_unittest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/chrome_browser.gypi
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/chrome_tests.gypi
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/test/BUILD.gn
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db.gypi
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/BUILD.gn
[modify]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/DEPS
[rename]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/database_manager.cc
[rename]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/database_manager.h
[add]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/hit_report.cc
[rename]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/hit_report.h
[rename]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/test_database_manager.cc
[rename]
http://crrev.com/76fc703b2570eb7fbde3174eefa5188e0e12f54b/components/safe_browsing_db/test_database_manager.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-22 21:24:11 UTC
Permalink
Comment #13 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c13

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/bdd302affda19c5b2051d1e868c7045f5614c955

commit bdd302affda19c5b2051d1e868c7045f5614c955
Author: vakh <***@chromium.org>
Date: Fri Jan 22 21:01:34 2016

Move remote_db_manager into the safe_browsing_db component.

BUG=543161

Review URL: https://codereview.chromium.org/1579403002

Cr-Commit-Position: refs/heads/master@{#371034}

[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/app/DEPS
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/app/android/chrome_main_delegate_android.cc
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/chromeos/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/safe_browsing/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/browser/safe_browsing/ui_manager.cc
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/chrome_android.gypi
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/chrome_browser.gypi
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/chrome_tests.gypi
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/chrome/test/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/components_tests.gyp
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db.gypi
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/BUILD.gn
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/DEPS
[modify]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/hit_report.h
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/metadata.proto
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/remote_database_manager.cc
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/remote_database_manager.h
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/remote_database_manager_unittest.cc
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/safe_browsing_api_handler.cc
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/safe_browsing_api_handler.h
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/safe_browsing_api_handler_unittest.cc
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/safe_browsing_api_handler_util.cc
[rename]
http://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955/components/safe_browsing_db/safe_browsing_api_handler_util.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-27 04:05:45 UTC
Permalink
Updates:
Cc: ***@chromium.org

Comment #15 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-01-27 22:52:21 UTC
Permalink
Comment #16 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c16

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4

commit ab09c80991a9dffc0a37c92e54c2e57f9deca8b4
Author: kcarattini <***@chromium.org>
Date: Wed Jan 27 22:27:51 2016

Remove unused foreground member variable from SB Protocol Manager.

BUG=543161,561867

Review URL: https://codereview.chromium.org/1640503003

Cr-Commit-Position: refs/heads/master@{#371897}

[modify]
http://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify]
http://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4/chrome/browser/android/chrome_application.cc
[modify]
http://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4/chrome/browser/safe_browsing/protocol_manager.cc
[modify]
http://crrev.com/ab09c80991a9dffc0a37c92e54c2e57f9deca8b4/chrome/browser/safe_browsing/protocol_manager.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-03 03:23:29 UTC
Permalink
Comment #18 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c18

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/b741a69f01ce186e750c4d5b371109b01a78e4cc

commit b741a69f01ce186e750c4d5b371109b01a78e4cc
Author: kcarattini <***@chromium.org>
Date: Wed Feb 03 02:26:28 2016

SafeBrowsing: Pull out v4 Protocol Manager into its own class.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1652863002

Cr-Commit-Position: refs/heads/master@{#373128}

[modify]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/protocol_manager.cc
[modify]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/protocol_manager.h
[modify]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[add]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/v4_protocol_manager.cc
[add]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/v4_protocol_manager.h
[add]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/browser/safe_browsing/v4_protocol_manager_unittest.cc
[modify]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/chrome_browser.gypi
[modify]
http://crrev.com/b741a69f01ce186e750c4d5b371109b01a78e4cc/chrome/chrome_tests_unit.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-03 05:03:36 UTC
Permalink
Comment #19 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c19

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/059fc092c7eb93ef703552e81fa90ee8305608ae

commit 059fc092c7eb93ef703552e81fa90ee8305608ae
Author: kcarattini <***@chromium.org>
Date: Wed Feb 03 03:46:39 2016

SafeBrowsing: Remove dependencies from V4ProtocolManager.

Removes dependencies of V4ProtocolManager on google_api_keys and
protocol_manager_helper in preparation for move to components.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1657183002

Cr-Commit-Position: refs/heads/master@{#373160}

[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/browser/safe_browsing/protocol_manager_helper.cc
[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/browser/safe_browsing/protocol_manager_helper.h
[delete]
http://crrev.com/d33c56b9855e28aa28565c0ea39bc70aacabe1b7/chrome/browser/safe_browsing/protocol_manager_helper_unittest.cc
[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/browser/safe_browsing/v4_protocol_manager.cc
[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/browser/safe_browsing/v4_protocol_manager.h
[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/browser/safe_browsing/v4_protocol_manager_unittest.cc
[modify]
http://crrev.com/059fc092c7eb93ef703552e81fa90ee8305608ae/chrome/chrome_tests_unit.gypi
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-03 06:06:39 UTC
Permalink
Comment #20 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c20

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/704ac0a8aa34d9afff877f1224c046f8ad422a55

commit 704ac0a8aa34d9afff877f1224c046f8ad422a55
Author: kcarattini <***@chromium.org>
Date: Wed Feb 03 05:33:44 2016

SafeBrowsing: Move V4ProtocolManager to components.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1658913003

Cr-Commit-Position: refs/heads/master@{#373183}

[modify]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/chrome/chrome_browser.gypi
[modify]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/chrome/chrome_tests_unit.gypi
[modify]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/components_tests.gyp
[modify]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/safe_browsing_db.gypi
[modify]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/safe_browsing_db/BUILD.gn
[rename]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/safe_browsing_db/v4_protocol_manager.cc
[rename]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/safe_browsing_db/v4_protocol_manager.h
[rename]
http://crrev.com/704ac0a8aa34d9afff877f1224c046f8ad422a55/components/safe_browsing_db/v4_protocol_manager_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-04 01:45:50 UTC
Permalink
Comment #21 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c21

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/16697f40e07b93472ddfff75f65a5cc8567d3de7

commit 16697f40e07b93472ddfff75f65a5cc8567d3de7
Author: kcarattini <***@chromium.org>
Date: Thu Feb 04 01:14:01 2016

SafeBrowsing: Create a custom histogram enum for V4 GetHash results.

None of the data collection code for this histogram is live yet so this
change should not affect any live metrics.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1657233002

Cr-Commit-Position: refs/heads/master@{#373410}

[modify]
http://crrev.com/16697f40e07b93472ddfff75f65a5cc8567d3de7/components/safe_browsing_db/v4_protocol_manager.h
[modify]
http://crrev.com/16697f40e07b93472ddfff75f65a5cc8567d3de7/tools/metrics/histograms/histograms.xml
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-08 04:37:34 UTC
Permalink
Comment #22 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c22

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/fbc763e4783f78f6b94e7a13eef934d12a4f16f1

commit fbc763e4783f78f6b94e7a13eef934d12a4f16f1
Author: kcarattini <***@chromium.org>
Date: Mon Feb 08 04:35:35 2016

SafeBrowsing: Remove unused histogram bucket.

MIN_WAIT_DURATION_ERROR was added in cl/1563763001 to account for v4 request
errors. V4 requests have since been moved to their own enum in cl/1657233002
and MIN_WAIT_DURATION_ERROR is unused in the SBGetHashResultType enum. This
bucket never recorded any metrics because the code is not live yet, so it is
safe to change the enum.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1664003002

Cr-Commit-Position: refs/heads/master@{#374082}

[modify]
http://crrev.com/fbc763e4783f78f6b94e7a13eef934d12a4f16f1/chrome/browser/safe_browsing/protocol_manager.h
[modify]
http://crrev.com/fbc763e4783f78f6b94e7a13eef934d12a4f16f1/tools/metrics/histograms/histograms.xml
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-17 00:55:50 UTC
Permalink
Comment #23 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c23

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/0b3f35792348a350345b0b2d2ca33e8c51211b03

commit 0b3f35792348a350345b0b2d2ca33e8c51211b03
Author: kcarattini <***@chromium.org>
Date: Wed Feb 17 00:29:34 2016

SafeBrowsing: Rename V4ProtocolManager to V4GetHashProtocolManager

The new V4 protocol managers will be spli into a gethash one and an
updates one.

BUG=561867,543161

Review URL: https://codereview.chromium.org/1701893002

Cr-Commit-Position: refs/heads/master@{#375725}

[modify]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/components_tests.gyp
[modify]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/safe_browsing_db.gypi
[modify]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/safe_browsing_db/BUILD.gn
[rename]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[rename]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[rename]
http://crrev.com/0b3f35792348a350345b0b2d2ca33e8c51211b03/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-17 05:12:54 UTC
Permalink
Comment #24 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c24

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/abc21066d6208d85f47fd34be9178d002be5d281

commit abc21066d6208d85f47fd34be9178d002be5d281
Author: kcarattini <***@chromium.org>
Date: Wed Feb 17 04:38:21 2016

SafeBrowsing: Move the v4 server url into util

BUG=561867,543161

Review URL: https://codereview.chromium.org/1704733002

Cr-Commit-Position: refs/heads/master@{#375792}

[modify]
http://crrev.com/abc21066d6208d85f47fd34be9178d002be5d281/components/safe_browsing_db/util.cc
[modify]
http://crrev.com/abc21066d6208d85f47fd34be9178d002be5d281/components/safe_browsing_db/util.h
[modify]
http://crrev.com/abc21066d6208d85f47fd34be9178d002be5d281/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 04:13:30 UTC
Permalink
Comment #25 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c25

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399

commit 95bba9fad50442a9ce7ae4fbcc50d1d845d5d399
Author: kcarattini <***@chromium.org>
Date: Thu Feb 18 04:10:31 2016

SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager

BUG=543161,561867

Review URL: https://codereview.chromium.org/1700943003

Cr-Commit-Position: refs/heads/master@{#376088}

[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/chrome/browser/safe_browsing/local_database_manager.cc
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/chrome/browser/safe_browsing/local_database_manager.h
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/chrome/browser/safe_browsing/safe_browsing_service.h
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/components/safe_browsing_db/BUILD.gn
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/components/safe_browsing_db/database_manager.cc
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/components/safe_browsing_db/database_manager.h
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/components/safe_browsing_db/remote_database_manager.cc
[modify]
http://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399/components/safe_browsing_db/remote_database_manager.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2016-02-18 09:53:47 UTC
Permalink
Comment #26 on issue 543161 by ***@chromium.org: Replace safe
browsing DB and update protocol with Pver4
https://code.google.com/p/chromium/issues/detail?id=543161#c26

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/8a7a2d7a721542025da871c789fe858f3bde1211

commit 8a7a2d7a721542025da871c789fe858f3bde1211
Author: henrika <***@chromium.org>
Date: Thu Feb 18 09:49:37 2016

Revert of SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager
(patchset #6 id:100001 of https://codereview.chromium.org/1700943003/ )

Reason for revert:
Speculative revert as Chrome sheriff. I suspect that this CL causes tons of
tests on Mac to fail. See e.g.
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/19690

Callstacks in all failing tests contains references to SafeBrowsing.

1 libbase.dylib 0x00000001195efbc3
_ZN4base5debug10StackTraceC1Ev + 35
2 sync_integration_tests 0x000000010a77225a
_ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC2Ev + 58
3 sync_integration_tests 0x000000010a757783
_ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC1Ev + 35
4 sync_integration_tests 0x000000010a757739
_ZN29SystemURLRequestContextGetterC2EP8IOThread + 105
5 sync_integration_tests 0x000000010a7577db
_ZN29SystemURLRequestContextGetterC1EP8IOThread + 43
6 sync_integration_tests 0x000000010a75c9a6
_ZN8IOThread24InitSystemRequestContextEv + 246
7 sync_integration_tests 0x000000010a75c866
_ZN8IOThread33system_url_request_context_getterEv + 358
8 sync_integration_tests 0x000000010a9b7cae
_ZN18BrowserProcessImpl22system_request_contextEv + 270
9 sync_integration_tests 0x000000010b1c0e55
_ZN13safe_browsing19SafeBrowsingService10InitializeEv + 101
10 sync_integration_tests 0x000000010a9bc17b
_ZN18BrowserProcessImpl25CreateSafeBrowsingServiceEv + 331
11 sync_integration_tests 0x000000010a9bbfe3
_ZN18BrowserProcessImpl21safe_browsing_serviceEv + 275
12 sync_integration_tests 0x000000010a8acf61
_ZN36ChromeResourceDispatcherHostDelegateC2Ev + 177
13 sync_integration_tests 0x000000010a8ad1d3
_ZN36ChromeResourceDispatcherHostDelegateC1Ev + 35
14 sync_integration_tests 0x000000010a9bcda5
_ZN18BrowserProcessImpl29ResourceDispatcherHostCreatedEv + 117
15 sync_integration_tests 0x000000010a6141c0
_ZN26ChromeContentBrowserClient29ResourceDispatcherHostCreatedEv + 320
16 libcontent.dylib 0x00000001212ba928
_ZN7content26ResourceDispatcherHostImplC2Ev + 1320
17 libcontent.dylib 0x00000001212baf63
_ZN7content26ResourceDispatcherHostImplC1Ev + 35
Post by c***@googlecode.com
SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager
BUG=543161,561867
Committed: https://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399
TBR=***@chromium.org,***@chromium.org,***@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161,561867

Review URL: https://codereview.chromium.org/1709943002

Cr-Commit-Position: refs/heads/master@{#376131}

[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/chrome/browser/safe_browsing/local_database_manager.cc
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/chrome/browser/safe_browsing/local_database_manager.h
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/chrome/browser/safe_browsing/safe_browsing_service.h
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/components/safe_browsing_db/BUILD.gn
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/components/safe_browsing_db/database_manager.cc
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/components/safe_browsing_db/database_manager.h
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/components/safe_browsing_db/remote_database_manager.cc
[modify]
http://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211/components/safe_browsing_db/remote_database_manager.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...