Comment #10 on issue 565765 by ***@chromium.org: [META] WTF cleanups
under Blink Onion Soup context
https://code.google.com/p/chromium/issues/detail?id=565765#c10
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a5466f457a195abd0f03066439c0efae3b5e14b0
commit a5466f457a195abd0f03066439c0efae3b5e14b0
Author: yutak <***@chromium.org>
Date: Tue Feb 16 06:58:50 2016
Blink Platform: Remove time functions from Platform.
Simplification!
To support the use case of mocking timers for tests, CurrentTime.h now
provides a customization function. Currently, it overrides the three
functions at once, but practically that wouldn't be a problem.
Some unit tests try to override timing functions by replacing
Platform. However, CachingCorrectnessTest and TextFinderTest seemed to
fail to do so, as they apparently lacked Platform::initialize()
calls. I'm not sure why these tests have not been failing. Anyways, this
patch "fixes" these issues, too.
BUG=565765
Review URL: https://codereview.chromium.org/1550563002
Cr-Commit-Position: refs/heads/master@{#375524}
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/content/child/blink_platform_impl.cc
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/content/child/blink_platform_impl.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/Timer.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/TimerTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/SafePoint.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/web/WebKit.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/CurrentTime.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/CurrentTime.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/DEPS
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/ThreadingPthreads.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/WTF.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/WTF.h
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/Source/wtf/testing/RunAllTests.cpp
[modify]
http://crrev.com/a5466f457a195abd0f03066439c0efae3b5e14b0/third_party/WebKit/public/platform/Platform.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
---
You received this message because you are subscribed to the Google Groups "Chromium-bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.