Issue 240576 in chromium: Migrate fullscreen to use top layer

[c***@googlecode.com]

Comment #6 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

The layout behavior of fixed-position elements is very different on mobile.
To make the matter more complicated, the behavior is going to change in
near future (http://goo.gl/aSEyF). It probably doesn't matter anymore
though. After some discussion we decided that it is most sensible to force
page scale factor the lowest possible value when entering fullscreen.

I have a few more question. How flexible is the fullscreen/backdrop pseudo
elements? Can we assign them different CSS positioning? Size that's smaller
than the screen? Opacity? Transparent background? I would imgine that some
people want such flexibity to implement feature like this:
http://lokeshdhakar.com/projects/lightbox2/

There are 2 known difficulties to support fancy backdrops:

1. Android (and possibly Google TV) uses special hardware overlay for
fullscreen video, for performance and DRM reason. We won't be able to
composite such hardware overlay. It has to be on bottom of everything. As
such, we won't be able to support anything that has a z-order lower than
the fullscreen'd video, like backdrop with background image or
transparency. The only backdrop we can do is a fullscreen blackout.

2. Need to implement placeholder for the fullscreen'd element. Otherwise
the document will reflow, which looks bad to the user. Another reason we
want a placeholder (whether to support fancy backdrops or not) is that
reflowing could mess up the scroll position.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #11 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

Sorry I put the top layer migration on hold for a bit because of the
Android fullscreen concerns. I have reconsidered and think it's OK to go
ahead. To summarize the issues:

1. For fullscreen video, we can't support ::backdrop due to the hardware
overlay. Nothing we can do.

2. Drawing an element (e.g., a modal dialog) on top of a fullscreen video
is not easy. trchen@ landed a change for drawing subtitles over the video.
However, it makes RenderVideo the root layer, which works because media
controls/subtitles are descendants of RenderVideo.

It seems possible to generalize this for top layer elements. Currently they
are children of RenderView. We can make instead make them children of
a "top layer" layer under RenderView, then make that layer the root layer
when it's necessary to render on top of a fullscreen video.

As a first pass, it's OK to punt on #2. It's a bug, but would not be a
regression.

3. Android wants to disable pinch zoom in fullscreen, so page scale is
forced to 1 for the whole page in fullscreen mode. With a
transparent ::backdrop, you'd see a bad jump as the pinch zoom changes.

I suspect in practice #3 won't be so terrible; the default fullscreen CSS
has an opaque ::backdrop and it's probably a rare page that wants
otherwise. But it is worth fixing if possible. One idea is to put the
fullscreened layers in a separate part of the CC layer tree unaffected by
page scale. This can be possible but a bit tricky: it must be possible for
other top layer elements like modal dialogs to be rendered above the
fullscreened element. They may go in the special part of the CC layer tree
too, but I think we want to allow pinch zoom for modal dialogs.

So I don't think 1-3 need to block this work, we'd get better modal
dialog/fullscreen interaction, more conformance with latest spec (IE
Preview is already supporting it) and it should clean up the hacky
RenderFullScreen.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: M-32

Comment #12 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #16 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
http://code.google.com/p/chromium/issues/detail?id=240576#c16

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=165710

------------------------------------------------------------------------
r165710 | ***@chromium.org | 2014-01-24T07:23:16.194798Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderInline.cpp?r1=165710&r2=165709&pathrev=165710
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder.html?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=165710&r2=165709&pathrev=165710
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/fullscreen.css?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.cpp?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.cpp?r1=165710&r2=165709&pathrev=165710
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-is-in-top-layer.html?r1=165710&r2=165709&pathrev=165710
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder-expected.txt?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.h?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Element.cpp?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayerCompositor.cpp?r1=165710&r2=165709&pathrev=165710
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-video-has-backdrop.html?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=165710&r2=165709&pathrev=165710
D
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.cpp?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.cpp?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.cpp?r1=165710&r2=165709&pathrev=165710
D
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.h?r1=165710&r2=165709&pathrev=165710
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/RenderTreeBuilder.cpp?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.h?r1=165710&r2=165709&pathrev=165710
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.h?r1=165710&r2=165709&pathrev=165710
D
Loading Image...

Replace RenderFullScreen with top layer

This patch makes the Fullscreen API use the top layer, as per the latest
Fullscreen spec:
http://fullscreen.spec.whatwg.org/

Some more details:
- HTMLPlugInElement now retains its widget during reattach. Otherwise,
a video would need to be reloaded when it enters fullscreen.
- The placeholder renderer that was in RenderFullScreen is removed. The
spec doesn't mention such a mechanism and it's better to avoid the
complexity if possible. It was originally added to prevent a flash of a
collapsed page when exiting fullscreen:
https://bugs.webkit.org/show_bug.cgi?id=61897
It's possible we still need it. Either way, it has to be moved from
RenderFullScreen.

Intent to ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yJUanvg7d40

BUG=240576,246077

Review URL: https://codereview.chromium.org/139743005
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #19 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
http://code.google.com/p/chromium/issues/detail?id=240576#c19

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=166114

------------------------------------------------------------------------
r166114 | ***@chromium.org | 2014-01-30T09:38:25.337586Z

Changed paths:
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-is-in-top-layer.html?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.cpp?r1=166114&r2=166113&pathrev=166114
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder-expected.txt?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.h?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayerCompositor.cpp?r1=166114&r2=166113&pathrev=166114
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-video-has-backdrop.html?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=166114&r2=166113&pathrev=166114
D
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.cpp?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.cpp?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.cpp?r1=166114&r2=166113&pathrev=166114
D
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.h?r1=166114&r2=166113&pathrev=166114
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/RenderTreeBuilder.cpp?r1=166114&r2=166113&pathrev=166114
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.h?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.h?r1=166114&r2=166113&pathrev=166114
D
Loading Image...
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderInline.cpp?r1=166114&r2=166113&pathrev=166114
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder.html?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=166114&r2=166113&pathrev=166114
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/fullscreen.css?r1=166114&r2=166113&pathrev=166114
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.cpp?r1=166114&r2=166113&pathrev=166114

Retry "Replace RenderFullScreen with top layer"

This patch makes the Fullscreen API use the top layer, as per the latest
Fullscreen spec. This retry fixes some tests/expectations.

Previously landed as r165904 and r165710
Codereviews:
https://codereview.chromium.org/134753003/
https://codereview.chromium.org/139743005/

BUG=240576, 246077

Review URL: https://codereview.chromium.org/142653003
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #20 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
http://code.google.com/p/chromium/issues/detail?id=240576#c20

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=166118

------------------------------------------------------------------------
r166118 | ***@chromium.org | 2014-01-30T11:04:39.555462Z

Changed paths:
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-video-has-backdrop.html?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=166118&r2=166117&pathrev=166118
A
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.cpp?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.cpp?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.cpp?r1=166118&r2=166117&pathrev=166118
A
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.h?r1=166118&r2=166117&pathrev=166118
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/RenderTreeBuilder.cpp?r1=166118&r2=166117&pathrev=166118
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.h?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.h?r1=166118&r2=166117&pathrev=166118
A
Loading Image...
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder.html?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderInline.cpp?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=166118&r2=166117&pathrev=166118
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/fullscreen.css?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.cpp?r1=166118&r2=166117&pathrev=166118
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-is-in-top-layer.html?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.cpp?r1=166118&r2=166117&pathrev=166118
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder-expected.txt?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.h?r1=166118&r2=166117&pathrev=166118
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayerCompositor.cpp?r1=166118&r2=166117&pathrev=166118

Revert of Retry "Replace RenderFullScreen with top layer"
(https://codereview.chromium.org/142653003/)

Reason for revert:
Flaky crashes on full-screen-element-stack.html
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/26189

This test also crashed after the last attempt, but it looked like it was
not due to this patch since it kept crashing well after that patch was
reverted. It looks real now though.

Post by c***@googlecode.com
Retry "Replace RenderFullScreen with top layer"
This patch makes the Fullscreen API use the top layer, as per the latest
Fullscreen spec. This retry fixes some tests/expectations.
Previously landed as r165904 and r165710
https://codereview.chromium.org/134753003/
https://codereview.chromium.org/139743005/
BUG=240576, 246077
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166114

TBR=***@chromium.org,***@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=240576, 246077

Review URL: https://codereview.chromium.org/134133004
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #22 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
http://code.google.com/p/chromium/issues/detail?id=240576#c22

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=166394

------------------------------------------------------------------------
r166394 | ***@chromium.org | 2014-02-04T13:07:43.686908Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/fullscreen.css?r1=166394&r2=166393&pathrev=166394
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-is-in-top-layer.html?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.cpp?r1=166394&r2=166393&pathrev=166394
D
Loading Image...
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder-expected.txt?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.h?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/anonymous-block-merge-crash.html?r1=166394&r2=166393&pathrev=166394
A
Loading Image...
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.cpp?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.cpp?r1=166394&r2=166393&pathrev=166394
A
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.h?r1=166394&r2=166393&pathrev=166394
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/RenderTreeBuilder.cpp?r1=166394&r2=166393&pathrev=166394
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt?r1=166394&r2=166393&pathrev=166394
D
Loading Image...
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-placeholder.html?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLPlugInElement.cpp?r1=166394&r2=166393&pathrev=166394
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/virtual/android?r1=166394&r2=166393&pathrev=166394
A
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/virtual/android/fullscreen?r1=166394&r2=166393&pathrev=166394
A
Loading Image...
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLDialogElement.h?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderLayerCompositor.cpp?r1=166394&r2=166393&pathrev=166394
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fullscreen/full-screen-video-has-backdrop.html?r1=166394&r2=166393&pathrev=166394
D
Loading Image...
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=166394&r2=166393&pathrev=166394
A
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderFullScreen.cpp?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/FullscreenElementStack.h?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVideo.h?r1=166394&r2=166393&pathrev=166394
A
Loading Image...
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderInline.cpp?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/Document.cpp?r1=166394&r2=166393&pathrev=166394
M
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=166394&r2=166393&pathrev=166394
D
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt?r1=166394&r2=166393&pathrev=166394
D
Loading Image...

Revert "Retry "Replace RenderFullScreen with top layer""

This reverts commit 9877946002a47509b8f737b756d5589812ec375c.

Revert "Auto-rebaseline for r166304"

This reverts commit ff6adb9065a035cb3604f067021da882544e5a93.

Revert "Mark full-screen-video-has-backdrop.html as flaky."

This reverts commit 850bb332da7a9bbdba68d91ecd9e1cf68abea612.

The change apparently breaks setAttribute behavior for plugins, though
there is not an easy repro test case yet.

BUG=240576,246077
TBR=hidehiko,esprehn
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/142703011
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Status: Available

Comment #23 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

Making available, I haven't worked on this in a while.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #24 on issue 240576 by ***@opera.com: Migrate fullscreen to use
top layer
http://code.google.com/p/chromium/issues/detail?id=240576

I'm currently looking a lot at the interaction between FullscreenController
and FullscreenElementStack, specifically at the timing of the
didEnterFullScreenForElement callback and when the fullscreenchange event
should be fired, i.e. issue 396575 and issue 396576.

Would moving fullscreen to the top layer have any influence on that
interaction?

The goal here should be to keep the event, rendering and all
script-observable state in perfect sync, and I don't want any efforts here
to be wasted...
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #25 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

I expect moving to top layer would affect only rendering and wouldn't have
an effect on events.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #26 on issue 240576 by ***@opera.com: Migrate fullscreen to use
top layer
http://code.google.com/p/chromium/issues/detail?id=240576

After looking at issue 357452 I'm more interested in this top layer stuff.
I see that it has been landed and reverted several times, can you explain
what the remaining work to land it is expected to be?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #27 on issue 240576 by ***@chromium.org: Migrate fullscreen to
use top layer
http://code.google.com/p/chromium/issues/detail?id=240576

The current RenderFullScreen does some trick to avoid reattaching plugin
elements when entering/exiting fullscreen:
https://bugs.webkit.org/show_bug.cgi?id=66531

If you reattach a plugin, it throws away the plugin widget. For a video,
that means you'd lose all the buffering/skipped advertisements/position,
and playback starts all over at the beginning of the video again.

Unfortunately, top layer probably requires a reattach. So, migrating
fullscreen to the top layer has to do some sort of trick to prevent the
plugin widget from being destroyed.

Each of my attempts to do this ended up regressing or crashing something
with plugins.

Note that issue 156219 attempts to move plugin lifetime out of the render
tree and into DOM, which should fix the whole issue. However, that work
seems stalled.

I think my final attempt was here:
https://codereview.chromium.org/138833005/
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: -Cr-Blink-Rendering Cr-Blink-Layout

Comment #30 on issue 240576 by ***@google.com: Migrate fullscreen to
use top layer
https://code.google.com/p/chromium/issues/detail?id=240576#c30

Migrate from Cr-Blink-Rendering to Cr-Blink-Layout
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: -Hotlist-Recharge

Comment #39 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
https://code.google.com/p/chromium/issues/detail?id=240576

Patch is in review ....
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #41 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
https://code.google.com/p/chromium/issues/detail?id=240576#c41

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2

commit 6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2
Author: dsinclair <***@chromium.org>
Date: Tue Oct 13 17:49:28 2015

Implement FullScreen using top layer.

This CL is based off of https://codereview.chromium.org/788073004 by
***@.

Replace RenderFullscreen with top layer - Take II

This patch is strongly inspired by
https://codereview.chromium.org/134753003/
but is a complete rewrite of the change to:
- understand why every bits was needed (some were not).
- better document the differences we have with the
specification so that we can track and fix them.

The issue with re-attaching plugins went away due to
https://codereview.chromium.org/23618022, which moved
the plugin's lifecycle to the DOM.

The tests' changes are because fullscreen doesn't center
by default anymore but stretches the element to the
viewport's size. Some tests were also not accounting
for the backdrop and where thus modified.

That change didn't land due to plugin persistence issues. Those issues
should now be resolved and plugins should survive over reattach.

BUG=240576, 246077, 398599
ORIGINAL_CL=https://codereview.chromium.org/1139033006/

Review URL: https://codereview.chromium.org/1363023005

Cr-Commit-Position: refs/heads/master@{#353782}

[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html
[add]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
[add]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
[add]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-video-has-backdrop-expected.html
[add]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-video-has-backdrop.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/core.gypi
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/css/fullscreen.css
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/dom/Document.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutBox.h
[delete]
http://crrev.com/37f5227e665fab5e3399a03fed72ce253a6669d0/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[delete]
http://crrev.com/37f5227e665fab5e3399a03fed72ce253a6669d0/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/core/layout/LayoutVideo.h
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/web/FullscreenController.cpp
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/web/FullscreenController.h
[modify]
http://crrev.com/6fe9d9762eb66a24bbbd3a5c2badf6e5ea98d1e2/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #43 on issue 240576 by ***@chromium.org: Migrate fullscreen
to use top layer
https://code.google.com/p/chromium/issues/detail?id=240576#c43

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/2460a95281959d1b4dd941fed10998adf8dcb63c

commit 2460a95281959d1b4dd941fed10998adf8dcb63c
Author: dsinclair <***@chromium.org>
Date: Wed Oct 21 16:51:44 2015

Revert "Implement FullScreen using top layer."

Reason for revert: Causes several issues when going into/out of fullscreen.

Implement FullScreen using top layer.

This CL is based off of https://codereview.chromium.org/788073004 by
***@.

Replace RenderFullscreen with top layer - Take II

This patch is strongly inspired by
https://codereview.chromium.org/134753003/
but is a complete rewrite of the change to:
- understand why every bits was needed (some were not).
- better document the differences we have with the
specification so that we can track and fix them.

The issue with re-attaching plugins went away due to
https://codereview.chromium.org/23618022, which moved
the plugin's lifecycle to the DOM.

The tests' changes are because fullscreen doesn't center
by default anymore but stretches the element to the
viewport's size. Some tests were also not accounting
for the backdrop and where thus modified.

That change didn't land due to plugin persistence issues. Those issues
should now be resolved and plugins should survive over reattach.

BUG=240576, 246077, 398599, 543946, 543954, 544175
ORIGINAL_CL=https://codereview.chromium.org/1139033006/

Review URL: https://codereview.chromium.org/1363023005

Cr-Commit-Position: refs/heads/master@{#353782}

Review URL: https://codereview.chromium.org/1410833004

Cr-Commit-Position: refs/heads/master@{#355313}

[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/SlowTests
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/TestExpectations
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen-expected.txt
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fast/css/invalidation/fullscreen.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/enter-exit-full-screen-hover.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/full-screen-iframe-zIndex-expected.html
[delete]
http://crrev.com/3f3f25c50a951d34ed1de305a5e9ea2c36a48be0/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer-expected.html
[delete]
http://crrev.com/3f3f25c50a951d34ed1de305a5e9ea2c36a48be0/third_party/WebKit/LayoutTests/fullscreen/full-screen-is-in-top-layer.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/full-screen-render-inline-expected.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context-expected.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/full-screen-stacking-context.html
[delete]
http://crrev.com/3f3f25c50a951d34ed1de305a5e9ea2c36a48be0/third_party/WebKit/LayoutTests/fullscreen/full-screen-video-has-backdrop-expected.html
[delete]
http://crrev.com/3f3f25c50a951d34ed1de305a5e9ea2c36a48be0/third_party/WebKit/LayoutTests/fullscreen/full-screen-video-has-backdrop.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/full-screen-zIndex-expected.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/resources/empty.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/LayoutTests/fullscreen/video-webkit-transform-expected.html
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/core.gypi
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/css/fullscreen.css
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/dom/Document.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutBox.h
[add]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[add]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutVideo.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/core/layout/LayoutVideo.h
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/web/FullscreenController.cpp
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/web/FullscreenController.h
[modify]
http://crrev.com/2460a95281959d1b4dd941fed10998adf8dcb63c/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #50 on issue 240576 by ***@gmail.com: Migrate fullscreen to use
top layer
https://code.google.com/p/chromium/issues/detail?id=240576

Firefox fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1126230
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings