Discussion:
Issue 333389 in chromium: "learn more" page in File Manager error redirects to empty page
(too old to reply)
c***@googlecode.com
2014-01-10 21:21:30 UTC
Permalink
Updates:
Summary: "learn more" page in File Manager error redirects to empty page
Owner: ***@chromium.org
Cc: -***@chromium.org
Labels: -Cr-Enterprise Cr-Platform-Apps-FileManager

Comment #2 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

This looks like a File Manager bug.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-10 21:29:30 UTC
Permalink
Updates:
Owner: ***@chromium.org
Cc: ***@chromium.org
Labels: -Type-Bug -Pri-2 Type-Bug-Regression Pri-1 Iteration-97

Comment #4 on issue 333389 by ***@google.com: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

@yoshiki - Can you please check and make sure the URL for c#0 is pointing
to https://support.google.com/chromebook/answer/1056323?hl=en?

Thanks!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-21 02:12:19 UTC
Permalink
Updates:
Owner: ***@chromium.org
Cc: ***@chromium.org
Labels: -Iteration-97 Iteration-98

Comment #5 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

I'll take this; I touched the code around help URL's in Files.app a lot.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-21 04:58:08 UTC
Permalink
Comment #6 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

The link expectedly points to
chrome-extension://offlinehelpappid/article.html?id=1061547
in the official image and
http://support.google.com/chromeos/bin/answer.py?answer=1061547
for chromium build.

target="_blank" link to chrome-extension:// URL may be causing some trouble.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-21 05:11:51 UTC
Permalink
Comment #7 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

So, this is chrome bug 332128.
Let me see if this is fundamentally fixable or quicker to add workaround in
Files.app side.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-21 05:36:53 UTC
Permalink
Updates:
Status: Started
Cc: ***@chromium.org

Comment #8 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389

...and I learned from stackoverflow
http://stackoverflow.com/questions/20019829/chrome-extension-links-open-aboutblank/20103129#20103129
that this is an intentional change in Chrome: http://crbug.com/173688.
Pages in extensions are no more accessible by <a href=""> links unless they
are explicitly marked in the extension manifest (and the offline help app
doesn't have it. cc:+cylee@ to be sure.)

I'll make a change to use chrome.tabs.create instead of <a> tag as all
other links in Files.app do.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-23 12:02:25 UTC
Permalink
Comment #9 on issue 333389 by ***@chromium.org: "learn more" page in
File Manager error redirects to empty page
http://code.google.com/p/chromium/issues/detail?id=333389#c9

------------------------------------------------------------------------
r246573 | ***@chromium.org | 2014-01-23T11:59:53.072637Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/foreground/js/drive_banners.js?r1=246573&r2=246572&pathrev=246573

Use chrome.tabs.create API for opening help page from Files.app.

When the help pages in chrome-extension:// URL, it cannot be opened from
<a href="..."> links. Along the way, strictified the condition to use
the offline help URL.

BUG=333389

Review URL: https://codereview.chromium.org/143883002
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Continue reading on narkive:
Loading...