Discussion:
Issue 18323 in chromium: Need more bits (64-bit Mac version)
(too old to reply)
c***@googlecode.com
2010-02-12 05:32:07 UTC
Permalink
Comment #8 on issue 18323 by cjmcqueen: Need more bits (64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

Chrome is one of the last apps I run that isn't 64-bit. Even Adobe is
making the change
and Safari is already there. Hope this can happen soon.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-02-19 16:16:12 UTC
Permalink
Comment #10 on issue 18323 by randy.secrist: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

found it strange this wasn't already 64-bit under OS -X. please get there
soon!

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-05-14 16:54:34 UTC
Permalink
Comment #13 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=47275

------------------------------------------------------------------------
r47275 | ***@chromium.org | 2010-05-14 08:43:00 -0700 (Fri, 14 May 2010) |
5 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest.cc?r1=47275&r2=47274
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest_mac.h?r1=47275&r2=47274
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_unittest_mac.mm?r1=47275&r2=47274

64-bit support for Mac OS X in base_unittests.

BUG=44127, 18323
TEST=64-bit base_unittests should all pass
Review URL: http://codereview.chromium.org/2126001
------------------------------------------------------------------------
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-05-14 21:13:18 UTC
Permalink
Updates:
Blockedon: 44215

Comment #17 on issue 18323 by ***@chromium.org: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

(No comment was entered for this change.)
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-05-14 21:41:52 UTC
Permalink
Comment #18 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=47308

------------------------------------------------------------------------
r47308 | ***@chromium.org | 2010-05-14 13:57:50 -0700 (Fri, 14 May 2010) |
5 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/skia/ext/skia_utils_mac.h?r1=47308&r2=47307

NSSize is equivalent to CGSize in the 64-bit Mac environment.

BUG=44215, 18323
TEST=none
Review URL: http://codereview.chromium.org/2134003
------------------------------------------------------------------------
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-09-17 05:22:04 UTC
Permalink
Comment #21 on issue 18323 by XuqingKuang: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

Yeah, Adobe has been released Flash plugin 64bit, we also Chrome can do so.
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-12-15 10:51:15 UTC
Permalink
Comment #25 on issue 18323 by deezahyn: Need more bits (64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

bumping
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-12-15 11:11:24 UTC
Permalink
Comment #26 on issue 18323 by AllanKimmerJensen: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

I want this soon!
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-12-15 11:27:34 UTC
Permalink
Comment #27 on issue 18323 by slippyd: Need more bits (64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

Note: As of now, Snow Leopard has been out for 16 months and it's not too
far-fetched to expect Lion in no more than 10 months.
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2010-12-15 11:31:34 UTC
Permalink
Comment #28 on issue 18323 by john.barr.rowe: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

The remaining work must be Mac bindings only, I'm running the 64 bit
version on Ubuntu 10.10 and it runs very well.

If you only judged 64 bit Chrome on the Linux version, you'd say it's been
ready for 8 months.

I'd really like that 64bit goodness on my Mac at home.
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2012-12-29 20:50:43 UTC
Permalink
Comment #48 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

Issue 167846 has been merged into this issue.
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2014-01-03 23:48:22 UTC
Permalink
Comment #63 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323#c63

The following revision refers to this bug:

http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=45719

------------------------------------------------------------------------
r45719 | ***@google.com | 2014-01-03T23:35:12.525120Z

------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-03 23:56:22 UTC
Permalink
Comment #64 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323#c64

------------------------------------------------------------------------
r242964 | ***@chromium.org | 2014-01-03T23:37:25.166215Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/build/mac/tweak_info_plist.py?r1=242964&r2=242963&pathrev=242964
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mac/keystone_install.sh?r1=242964&r2=242963&pathrev=242964
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mac/keystone_glue.mm?r1=242964&r2=242963&pathrev=242964

Expand the Keystone tag to contain the system's CPU's bitness and whether a
full installer is desired.

Formerly, the tag identified only the channel that Chrome was on. The tag is
being enhanced to detect the CPU's bitness (adding "-32bit" for 32-bit-only,
non-64-bit-capable CPUs) and whether a full (as opposed to binary diff
patch)
update is requested (adding "-full").

CPU bitness detection ought to be a feature of Keystone, but Keystone uses
the
NXGetLocalArchInfo to determine the CPU type, and winds up always reporting
"i486". The "-32bit" tag suffix will be present whenever the
"hw.cpu64bit_capable" sysctl name is not found or has value 0. This enables
proper detection of users who are capable of running 64-bit Chrome on the
server side.

When a binary diff patch update application fails in dirpatcher, typically
the
result of modifications made to existing installations, the "-full" tag
suffix
will be set. On a subsequent update attempt, the server can detect this
value
and provide the client with a full updater package, which does not depend on
the existing installation. The "-full" tag suffix is cleared on successful
update installation.

BUG=18323,54047,225352,303280,316916
R=***@chromium.org

Review URL: https://codereview.chromium.org/102963007
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-06 14:41:26 UTC
Permalink
Comment #65 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323#c65

------------------------------------------------------------------------
r243088 | ***@chromium.org | 2014-01-06T14:36:43.031619Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mac/keystone_install.sh?r1=243088&r2=243087&pathrev=243088

Make the update installer fail when attempting to install a 64-bit-only
update
on a 32-bit-only system.

The server infrastructure should not deliver 64-bit-only updates to
32-bit-only systems, but this depends on the new -32bit tag suffix support
already being on the system prior to the attempted delivery of a 64-bit-only
update. The update installer will now sanity-check this, and if the system
will not be capable of running the updated version, it will exit before
attempting to install it. Additionally, it will set the -32bit tag suffix so
that during a subsequent update check, the server should deliver the proper
32-bit-only update (likely the final 32-bit version), or no update at all.

This also serves as a failsafe against breaking users on 32-bit-only systems
if the server-side -32bit tag suffix detection isn't working properly.

BUG=18323,303280
R=***@chromium.org, thakis

Review URL: https://codereview.chromium.org/124813002
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-06 17:36:12 UTC
Permalink
Updates:
Labels: merge-merged-1750

Comment #66 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323#c66

------------------------------------------------------------------------
r243102 | ***@chromium.org | 2014-01-06T16:59:03.446041Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1750/src/chrome/installer/mac/keystone_install.sh?r1=243102&r2=243101&pathrev=243102
M
http://src.chromium.org/viewvc/chrome/branches/1750/src/chrome/browser/mac/keystone_glue.mm?r1=243102&r2=243101&pathrev=243102
M
http://src.chromium.org/viewvc/chrome/branches/1750/src/build/mac/tweak_info_plist.py?r1=243102&r2=243101&pathrev=243102

Merge trunk r242964 and r243035 to the 33.0.1750 branch.
Post by c***@googlecode.com
Expand the Keystone tag to contain the system's CPU's bitness and whether
a
full installer is desired.
Formerly, the tag identified only the channel that Chrome was on. The tag
is
being enhanced to detect the CPU's bitness (adding "-32bit" for
32-bit-only,
non-64-bit-capable CPUs) and whether a full (as opposed to binary diff
patch)
update is requested (adding "-full").
CPU bitness detection ought to be a feature of Keystone, but Keystone
uses the
NXGetLocalArchInfo to determine the CPU type, and winds up always
reporting
"i486". The "-32bit" tag suffix will be present whenever the
"hw.cpu64bit_capable" sysctl name is not found or has value 0. This
enables
proper detection of users who are capable of running 64-bit Chrome on the
server side.
When a binary diff patch update application fails in dirpatcher,
typically the
result of modifications made to existing installations, the "-full" tag
suffix
will be set. On a subsequent update attempt, the server can detect this
value
and provide the client with a full updater package, which does not depend
on
the existing installation. The "-full" tag suffix is cleared on successful
update installation.
BUG=18323,54047,225352,303280,316916
Review URL: https://codereview.chromium.org/102963007
Switch exit status from 77 (try again later) back to 12/13 (errors).
When driving an update from KeystoneRegistration, Chrome sees 77 as
success.
This causes the about page to say that an update was successfully
installed
and offer the option to relaunch. When the user clicks Relaunch, Chrome
quits
and the same old version restarts and starts trying to apply an update
again.
This seems kind of glitchy.
I'm switching back to the failure codes, because those are properly
reported
in the UI. In the future, I can make keystone_glue.mm check for the
.want_full_installer file when update installation fails and silently
retry
installation once, for a seamless "error 12"-free experience.
BUG=54047,303280
TBR=thakis
Review URL: https://codereview.chromium.org/121673003
Review URL: https://codereview.chromium.org/122713003
------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-01-06 17:48:13 UTC
Permalink
Comment #67 on issue 18323 by ***@chromium.org: Need more bits
(64-bit Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323#c67

The following revision refers to this bug:

http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=45762

------------------------------------------------------------------------
r45762 | ***@google.com | 2014-01-06T17:03:33.627806Z

------------------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-02-11 17:24:42 UTC
Permalink
Updates:
Blockedon: chromium:337859

Comment #68 on issue 18323 by ***@chromium.org: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

Issue 337859 exposes misaligned memory accesses on 64. Seems like this
broke after the canary we did.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-03-17 04:47:22 UTC
Permalink
Updates:
Blockedon: chromium:353047

Comment #70 on issue 18323 by ***@chromium.org: Need more bits (64-bit
Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-14 15:45:03 UTC
Permalink
Updates:
Blockedon: chromium:393594

Comment #71 on issue 18323 by ***@chromium.org: Need more bits (64-bit
Mac version)
http://code.google.com/p/chromium/issues/detail?id=18323

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-07-24 02:28:58 UTC
Permalink
Updates:
Blockedon: chromium:396957

Comment #72 on issue 18323 by ***@chromium.org: Need more bits (64-bit Mac
version)
http://code.google.com/p/chromium/issues/detail?id=18323

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-11-18 21:22:05 UTC
Permalink
Updates:
Status: Fixed

Comment #73 on issue 18323 by ***@chromium.org: Need more bits (64-bit Mac
version)
https://code.google.com/p/chromium/issues/detail?id=18323

This was released to the stable channel today in version 39.0.2171.65.
Thanks for your patience, everyone.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Continue reading on narkive:
Loading...