c***@googlecode.com
2015-08-21 01:11:35 UTC
Comment #1 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c1
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8440052c7882f61cfde793f687e72717c85e0d8f
commit 8440052c7882f61cfde793f687e72717c85e0d8f
Author: jww <***@chromium.org>
Date: Fri Aug 21 01:05:47 2015
Setup for moving getUserMedia to secure origins only
This makes two notable changes:
* Removes the browser tests that verify that the getUserMedia
permission is not "sticky" on insecure origins.
* Moves the addition of the chrome-extension: and
chrome-extension-resource: schemes to extensions::Dispatcher.
The former is necessary because once getUserMedia is removed from
insecure origins, the browser test will (correctly) fail. Thus this is
part of a two sided patch.
The later is necessary because extension browser tests that use
getUserMedia will start failing once the change is made, because the
tests use ShellContentRendererClient, which doesn't currently treat
chrome-extension: schemes as secure, so getUserMedia will be disallowed
by the renderer. By marking the scheme as secure in
extensions::Dispatcher instead of in
ChromeContentRendererClient::RenderThreadStarted, the schemes will be
marked as secure in ShellContentRendererClient as well, so getUserMedia
will be allowed in the browser tests.
BUG=520765
Review URL: https://codereview.chromium.org/1301653005
Cr-Commit-Position: refs/heads/master@{#344635}
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/renderer/chrome_content_renderer_client.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/renderer/dispatcher.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/shell/renderer/shell_content_renderer_client.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c1
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/8440052c7882f61cfde793f687e72717c85e0d8f
commit 8440052c7882f61cfde793f687e72717c85e0d8f
Author: jww <***@chromium.org>
Date: Fri Aug 21 01:05:47 2015
Setup for moving getUserMedia to secure origins only
This makes two notable changes:
* Removes the browser tests that verify that the getUserMedia
permission is not "sticky" on insecure origins.
* Moves the addition of the chrome-extension: and
chrome-extension-resource: schemes to extensions::Dispatcher.
The former is necessary because once getUserMedia is removed from
insecure origins, the browser test will (correctly) fail. Thus this is
part of a two sided patch.
The later is necessary because extension browser tests that use
getUserMedia will start failing once the change is made, because the
tests use ShellContentRendererClient, which doesn't currently treat
chrome-extension: schemes as secure, so getUserMedia will be disallowed
by the renderer. By marking the scheme as secure in
extensions::Dispatcher instead of in
ChromeContentRendererClient::RenderThreadStarted, the schemes will be
marked as secure in ShellContentRendererClient as well, so getUserMedia
will be allowed in the browser tests.
BUG=520765
Review URL: https://codereview.chromium.org/1301653005
Cr-Commit-Position: refs/heads/master@{#344635}
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/renderer/chrome_content_renderer_client.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/renderer/dispatcher.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/shell/renderer/shell_content_renderer_client.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.