Re: Issue 520765 in chromium: Deprecation and removal of powerful features on insecure origins

[c***@googlecode.com]

Comment #1 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c1

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/8440052c7882f61cfde793f687e72717c85e0d8f

commit 8440052c7882f61cfde793f687e72717c85e0d8f
Author: jww <***@chromium.org>
Date: Fri Aug 21 01:05:47 2015

Setup for moving getUserMedia to secure origins only

This makes two notable changes:
* Removes the browser tests that verify that the getUserMedia
permission is not "sticky" on insecure origins.
* Moves the addition of the chrome-extension: and
chrome-extension-resource: schemes to extensions::Dispatcher.

The former is necessary because once getUserMedia is removed from
insecure origins, the browser test will (correctly) fail. Thus this is
part of a two sided patch.

The later is necessary because extension browser tests that use
getUserMedia will start failing once the change is made, because the
tests use ShellContentRendererClient, which doesn't currently treat
chrome-extension: schemes as secure, so getUserMedia will be disallowed
by the renderer. By marking the scheme as secure in
extensions::Dispatcher instead of in
ChromeContentRendererClient::RenderThreadStarted, the schemes will be
marked as secure in ShellContentRendererClient as well, so getUserMedia
will be allowed in the browser tests.

BUG=520765

Review URL: https://codereview.chromium.org/1301653005

Cr-Commit-Position: refs/heads/master@{#344635}

[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/chrome/renderer/chrome_content_renderer_client.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/renderer/dispatcher.cc
[modify]
http://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f/extensions/shell/renderer/shell_content_renderer_client.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #4 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c4

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/f0d3f1086f14baddc8914d3683125c65c4eed82c

commit f0d3f1086f14baddc8914d3683125c65c4eed82c
Author: phoglund <***@chromium.org>
Date: Tue Aug 25 16:42:17 2015

Now pulling WebRTC telemetry pages from https instead of http.

https://codereview.chromium.org/1301653005 changed getUserMedia so it
only works for secure origins, which led gUM to be blocked. This patch
makes us pull our demo pages from https instead of http. Web page
replay seems to respect https, and will play back as https, so this
should solve the problem.

BUG=520765,523517
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1313873002

Cr-Commit-Position: refs/heads/master@{#345350}

[modify]
http://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c/tools/perf/benchmarks/webrtc.py
[modify]
http://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c/tools/perf/page_sets/data/webrtc_cases.json
[add]
http://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c/tools/perf/page_sets/data/webrtc_cases_013.wpr.sha1
[modify]
http://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c/tools/perf/page_sets/webrtc_cases.py
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #6 on issue 520765 by ***@chromium.org: Deprecation and removal
of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

jww: it seems like this would make it impossible for users to add
exceptions for http sites. Is that intended? Should this be something we
want to support? I've had the impression that palmer@ has been in favour of
allowing users to add arbitrary exceptions in the past.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #11 on issue 520765 by jhiswin: Deprecation and removal of powerful
features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

Is this really necessary, and is there some kind of alternative?

Forcing the use of https for simple recording is really inconvenient. For
example, I'm using getUserMedia to record short clips for some web
exercises.

Can't it just be something like requiring user input to start, or popping
up some kind of large notification that they are being recorded?

Forcing a pop-up for permissions every time the page is loaded is already
enough of an inconvenience, and not all of us need or have the resources to
use https:// for everything.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #12 on issue 520765 by ***@gmail.com: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

As this is a breaking change, I think it should be publicized a lot more.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #13 on issue 520765 by ***@chromium.org: Deprecation and removal of
powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

re #11, yes, it is necessary. Please see the earlier discussions (in
particular the link to blink-dev) which talk about why your proposals are
insufficient.

re #12, it will be publicized in the near future (although note that per
the numbers cited earlier, this is actually not very widely used, so it
shouldn't affect that many users).
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: Merge-Request-46

Comment #14 on issue 520765 by ***@chromium.org: Deprecation and removal of
powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

We actually need a second merge as well to complete the revert. Can I get
merge approval for a revert of 568020793451c5b6e9a5cd44e08fef4a9c83a77e to
M-46? Thanks.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: -Merge-Request-46 Merge-Approved-46

Comment #15 on issue 520765 by ***@google.com: Deprecation and removal
of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c15

Approved for M46 (branch: 2490)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #20 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c20

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/bf2fce2b76dd44c7b93b285c81e35135dc446e56

commit bf2fce2b76dd44c7b93b285c81e35135dc446e56
Author: ***@chromium.org <***@chromium.org>
Date: Thu Sep 10 17:37:18 2015

Revert "Removal of getUserMedia() on insecure origins"

This reverts commit 568020793451c5b6e9a5cd44e08fef4a9c83a77e.

Reason for this revert: Decision to delay removal of getUserMedia() from
insecure origins until after M46.

BUG=520765
TBR=***@opera.com,***@chromium.org

Review URL: https://codereview.chromium.org/1336633002 .

git-svn-id: svn://svn.chromium.org/blink/branches/chromium/***@202062
bbb929c8-8fbe-4397-9dbb-9b2b20218538

[add]
http://crrev.com/bf2fce2b76dd44c7b93b285c81e35135dc446e56/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/getUserMedia-on-insecure-origin.html
[modify]
http://crrev.com/bf2fce2b76dd44c7b93b285c81e35135dc446e56/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt
[modify]
http://crrev.com/bf2fce2b76dd44c7b93b285c81e35135dc446e56/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
[modify]
http://crrev.com/bf2fce2b76dd44c7b93b285c81e35135dc446e56/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify]
http://crrev.com/bf2fce2b76dd44c7b93b285c81e35135dc446e56/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #27 on issue 520765 by ***@chromium.org: Deprecation and removal
of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

This is progressing too fast! Please contribute to letsencrypt or some
other solutions before screwing all hobbiest devs over. Some of us don't
have $200-$500 per website to spend and the only free solution,
letsencrypt, currently only supports apache without tons of work.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #29 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c29

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/33ef9f5c8df422b0320cbc506d57bdce2999ebc8

commit 33ef9f5c8df422b0320cbc506d57bdce2999ebc8
Author: jww <***@chromium.org>
Date: Fri Dec 11 07:34:21 2015

Removal of geolocation APIs on insecure origins

This disallows the geolocation APIs getCurrentPosition() and
watchPosition() from being used on insecure origins. Adds a console
warning message that the API call has failed because of this.

BUG=520765,561641

Review URL: https://codereview.chromium.org/1485973002

Cr-Commit-Position: refs/heads/master@{#364642}

[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/chrome/browser/geolocation/geolocation_permission_context.cc
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify]
http://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #30 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c30

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/ecdcb8846d510107b97b8401b81ec06462420f15

commit ecdcb8846d510107b97b8401b81ec06462420f15
Author: johnme <***@chromium.org>
Date: Fri Dec 11 13:26:32 2015

Revert of Removal of geolocation APIs on insecure origins (patchset #6
id:100001 of https://codereview.chromium.org/1485973002/ )

Reason for revert:
Sorry, this broke the following WebView CTS tests:

android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestAcceptAlways
android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestAcceptOnce
android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestReject

See
https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/4704

It seems that might be intentional, but turning the bot red doesn't seem
great. sgurun@ can probably advise on whether WebView has test expectations
for CTS, that could be used to disable these tests.

Post by c***@googlecode.com
Removal of geolocation APIs on insecure origins
This disallows the geolocation APIs getCurrentPosition() and
watchPosition() from being used on insecure origins. Adds a console
warning message that the API call has failed because of this.
BUG=520765,561641
Committed: https://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8

TBR=***@chromium.org,***@opera.com,***@chromium.org,***@chromium.org,***@chromium.org,***@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=520765,561641

Review URL: https://codereview.chromium.org/1515103003

Cr-Commit-Position: refs/heads/master@{#364689}

[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/chrome/browser/geolocation/geolocation_permission_context.cc
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify]
http://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #31 on issue 520765 by ***@gmail.com: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

This breaks the majority of the webcam input 'Chrome experiments' that are
showcased via https://www.chromeexperiments.com/webcam-input
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #32 on issue 520765 by ***@chromium.org: Deprecation and removal of
powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

That's a great point. I'll start an internal Google thread about getting
that fixed.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #33 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765#c33

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1

commit 9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1
Author: jww <***@chromium.org>
Date: Tue Jan 19 20:58:59 2016

Removal of geolocation APIs on insecure origins

This disallows the geolocation APIs getCurrentPosition() and
watchPosition() from being used on insecure origins. Adds a console
warning message that the API call has failed because of this.

Note that this is a re-land of
https://codereview.chromium.org/1485973002/. See that CL for full
discussion.

BUG=520765, 561641
TBR=***@chromium.org,***@chromium.org,***@opera.com,***@chromium.org

Review URL: https://codereview.chromium.org/1530403002

Cr-Commit-Position: refs/heads/master@{#370185}

[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/android_webview/native/aw_settings.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/chrome/browser/geolocation/geolocation_permission_context.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/content/public/common/common_param_traits_macros.h
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/content/public/common/content_switches.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/content/public/common/web_preferences.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/content/public/common/web_preferences.h
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/content/renderer/render_view_impl.cc
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/Source/core/frame/Settings.in
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/Source/web/WebSettingsImpl.h
[modify]
http://crrev.com/9d4ca2d9838b5f33bdb3f8fcfb8ef381d449b2a1/third_party/WebKit/public/web/WebSettings.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: Cr-Blink-Location

Comment #34 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Labels: -Cr-Blink-Location

Comment #35 on issue 520765 by ***@chromium.org: Deprecation and
removal of powerful features on insecure origins
https://code.google.com/p/chromium/issues/detail?id=520765

Actually, it looks like the geolocation work is done here, but this issue
won't be closed yet.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings