Discussion:
Issue 177322 in chromium: [DOGFOOD BLOCKING] IME input is prematurely committed upon gray text completion appearing
(too old to reply)
c***@googlecode.com
2013-02-21 02:52:56 UTC
Permalink
Updates:
Summary: [DOGFOOD BLOCKING] IME input is prematurely committed upon gray
text completion appearing
Labels: OS-Windows

Comment #6 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Need this for dogfood.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-21 03:08:56 UTC
Permalink
Updates:
Cc: ***@chromium.org ***@chromium.org ***@chromium.org
***@chromium.org

Comment #7 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Adding yuki@, kochi@ since fixing this the proper way would help us with
our plan to improve the Omnibox + IME (/ multiple input method)

Adding horo@ for Mac + IME expertise and yukawa@ for Windows + IME
expertise.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-21 06:10:32 UTC
Permalink
Comment #8 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I tried this, and this reproduced on OSX 10.8.2, not reproducing on Windows7
(both canary).
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-21 06:15:59 UTC
Permalink
Comment #9 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Interesting - I was able to repro on Win8 with the default Japanese IME.
Did you try typing slowly, and giving time for the gray text completions to
come through? It doesn't always reproduce; it seems to be a race between
the gray text and the candidates.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-21 06:58:23 UTC
Permalink
Comment #10 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I tried to reproduce this issue on Windows but didn't succeed.
My environment is Chrome 27.0.1418.2 canary + Windows 7 (64-bit) on VMWare.
The gray text came up beside a query in Omnibox, but it wasn't committed.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-21 07:07:04 UTC
Permalink
Comment #11 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

The issue doesn't reproduce on Ubuntu + Chrome 27.0.1419.0 (ToT build).

By the way, TAB key completes [こんに] to [こんにゃく] as expected, but
right arrow key doesn't work. I expected right arrow key completes the
query.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-27 07:18:27 UTC
Permalink
Comment #16 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Can you tell me the code location which appends "ゃく" (xyaku) to "こんに"
(konnni) on Mac? That is #4 of the repro steps.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-02-27 09:58:27 UTC
Permalink
Comment #17 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I identified the code, c/b/ui/cocoa/omnibox/omnibox_view_mac.mm.

I'm not so familiar with how to interact with IME on OSX, but from reading
the comment in OmniboxViewMac::OnStartingIME():
// Reset the suggest text just before starting an IME composition session,
// otherwise the IME composition may be interrupted when the suggest text
// gets reset by the IME composition change.
we should avoid modifying text while IME is on.

I made a tentative fix for this.
https://codereview.chromium.org/12316156/

This disables instant inline autocompletion while IME is on, but perhaps it
is
inevitable on OSX.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-01 02:57:41 UTC
Permalink
Updates:
Cc: ***@chromium.org

Comment #30 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Scott wanted me to try a couple of different approaches to fix this bug.

For reference here are the 3 I've tried:
(1) Add sibling view of the field editor to draw suggest text
https://codereview.chromium.org/12388008/#ps7001
(2) Add a child view of the field editor to draw suggest text
https://codereview.chromium.org/12388008/#ps6
(3) Custom draw rect, don't add any views
https://codereview.chromium.org/12388008/#ps10001

I have test builds for the 3 different approaches here:
(1)
https://docs.google.com/file/d/0B0Odde3V7EhWX3VSUTV3WXJsM1k/edit?usp=sharing
(2)
https://docs.google.com/file/d/0B0Odde3V7EhWaXhMR05wTGN1X2M/edit?usp=sharing
(3)
https://docs.google.com/a/google.com/file/d/0B0NW6HDVwlyud2VzTlRCTUcwNEE/edit?usp=sharing
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-06 14:38:54 UTC
Permalink
Updates:
Status: Fixed

Comment #33 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-06 22:23:27 UTC
Permalink
Comment #34 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

when type mahou Displaying IME popup please see attached screen
typemahou.png
after mahou when press spacebar IME popup is gone away and gray text is
shown on omnibox please see attached screen space_no.png

please let me know whether verification is done correctly, if not please
ask japanese expert to verify the bug

Thanks

Attachments:
typemahou.png 34.4 KB
space_no.png 32.7 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-07 04:21:16 UTC
Permalink
Comment #37 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I'll also test the latest canary.
Sail, thanks for working on this!
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-07 09:14:28 UTC
Permalink
Comment #38 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I built ToT Chromium myself, and tried it.

Typing "こんに" sometimes autocompleted "こんに"(black) + "ゃく"(gray)
without
committing the IME composition, but sometimes not.
But if I commit "こんに", then it worked 100%.

Even when the autocomplete didn't appear, the search result was for "こんに
ゃく",
which may be confusing to users.

Maybe this is due to my bad build, or Chromium is too slow because it is
debug build.
I'll try canary tomorrow anyway.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-07 17:25:07 UTC
Permalink
Comment #39 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Thank you very much for playing with it! I'll be curious if it's any better
on Canary.

In the cases where it didn't complete without committing the composition,
was that because it didn't complete at all, or because it incorrectly
committed too early for you?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 04:24:21 UTC
Permalink
Comment #40 on issue 177322 by ***@google.com: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Tested today's canary (Version 27.0.1432.0 canary).

The same behavior with Kochi's report happened.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 04:35:21 UTC
Permalink
Comment #41 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Okay, thanks for checking. Could you answer my question from comment #39?

In the cases where it didn't complete without committing the composition,
was that because it didn't complete at all, or because it incorrectly
committed too early for you?

Any time you might have to help us investigate what's going wrong here
would be hugely helpful! Even just steps for how to make it misbehave.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 04:48:21 UTC
Permalink
Comment #42 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I think the original issue is actually fixed (IME input is not anymore
prematurely committed upon autocompletion).

But there are a couple of different issues for which we should probably
file new bugs.
I have potentially 3 bugs.
I will cc gideonwald for triage.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 04:56:21 UTC
Permalink
Comment #43 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I tried today's canary.

For me, the gray autocomplete was very flaky.

For "こんに" example, sometimes autocompletes immediately, while in some
cases it takes 3-5 seconds or it never autocompletes. It happens very
randomly
and haven't found any reliable way to reproduce the case that fails.

Re #39, canary doesn't incorrectly commit composition. In that sense, the
original
issue is addressed, but showing search results with autocompleted word
without showing autocompleted suffix is still an issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 05:01:21 UTC
Permalink
Comment #44 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING]
IME input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

Okay, sounds good. I agree with filing separate bugs.

Can you guys confirm that you don't see those bugs manifesting on Win and
CrOS in today's Canary?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
c***@googlecode.com
2013-03-08 05:41:02 UTC
Permalink
Comment #45 on issue 177322 by ***@chromium.org: [DOGFOOD BLOCKING] IME
input is prematurely committed upon gray text completion appearing
http://code.google.com/p/chromium/issues/detail?id=177322

I will test on Mac, CrOS and Win7/8.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs
Loading...