Discussion:
Issue 323422 in chromium: Grant permissions per mount point in chrome.fileBrowserPrivate.requestFileSystem().
(too old to reply)
c***@googlecode.com
2014-03-03 02:38:45 UTC
Permalink
Updates:
Cc: ***@chromium.org

Comment #8 on issue 323422 by ***@chromium.org: Grant permissions per
mount point in chrome.fileBrowserPrivate.requestFileSystem().
http://code.google.com/p/chromium/issues/detail?id=323422

@kinaba: I'd like to clean up permissions and grant the permissions only to
the requested volume, eg. /drive, or /archive/test, since there is
no 'global' filesystem object anymore. But I just noticed
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc&l=245.
Do you think we could avoid this, and grant permissions on demand? WDYT?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2014-03-03 04:22:09 UTC
Permalink
Comment #9 on issue 323422 by ***@chromium.org: Grant permissions per
mount point in chrome.fileBrowserPrivate.requestFileSystem().
http://code.google.com/p/chromium/issues/detail?id=323422

Hm, sounds reasonable.

The purpose of the permission given there (and also
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chromeos/extensions/file_manager/event_router.cc&l=321)
is to grant access to the source entries in cross-profile copy/move. Thus,
we basically have control over the point where the grant is indeed used.

I think there are two ways to avoid the issue,

* Change VolumeManager to mount not only the profile's own folders but also
other profile's. Then Files.app will requestFileSystem() for the volume and
be explicitly granted. We need to treat such volumes as mounted yet still
hidden in Files.app UI.

or

* file_transfer_controller.js requests permissions to the dropped/pasted
filesystem URLs each time before starting transfer. This might need
additional private API because in the current design we can only
requestFileSystem() via volume ID, which will not be assigned unless we
take the first approach.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-10 02:58:38 UTC
Permalink
Updates:
Labels: -Pri-2 M-43 Week-1511 Pri-1

Comment #22 on issue 323422 by ***@chromium.org: Grant permissions per
mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422

Needed for chrome.fileSystem.requestFileSystem.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-10 03:01:38 UTC
Permalink
Issue 323422: Grant permissions per mount point in
chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422

This issue is now blocking issue chromium:440674.
See https://code.google.com/p/chromium/issues/detail?id=440674

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-10 03:02:38 UTC
Permalink
Updates:
Status: Started

Comment #24 on issue 323422 by ***@chromium.org: Grant permissions per
mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-11 09:59:47 UTC
Permalink
Comment #25 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c25

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/b07d623e7729e334e1fa0550f8038e73084a2d2a

commit b07d623e7729e334e1fa0550f8038e73084a2d2a
Author: Tomasz Mikolajewski <***@chromium.org>
Date: Wed Mar 11 09:52:53 2015

Grant permissions to other profile files on demand.

Previously, Files app was being granted permissions to all volumes even if
not all of them were requested or needed.

This is the first patch of the larger effort in order to grant permissions
to
only what's needed. This CL grants pemissions to other-profile files before
performing a paste operation for that files.

TEST=Tested manually with multiple profiles.
BUG=323422
R=***@chromium.org, ***@chromium.org, ***@chromium.org,
***@chromium.org

Review URL: https://codereview.chromium.org/993873002

Cr-Commit-Position: refs/heads/master@{#320063}

[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/chrome/browser/chromeos/extensions/file_manager/event_router.h
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/chrome/common/extensions/api/file_manager_private.idl
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/extensions/browser/extension_function_histogram_value.h
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/third_party/closure_compiler/externs/file_manager_private.js
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/tools/metrics/histograms/histograms.xml
[modify]
http://crrev.com/b07d623e7729e334e1fa0550f8038e73084a2d2a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-13 06:28:02 UTC
Permalink
Comment #27 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c27

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/b72ec427905846d002f9dde5b3555c40d6b9d0cf

commit b72ec427905846d002f9dde5b3555c40d6b9d0cf
Author: mtomasz <***@chromium.org>
Date: Fri Mar 13 06:09:04 2015

Extract the external file scheme granting out of requestFileSystem in Files
app.

The requestFileSystem method is going to be moved to chrome.fileSystem and
will
be used by other apps, so all Files app specific should be extracted before
moving.

TEST=Tested manually by dragging a file from Drive to a browser tab.
BUG=323422

Review URL: https://codereview.chromium.org/997483003

Cr-Commit-Position: refs/heads/master@{#320459}

[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/chrome/common/extensions/api/file_manager_private.idl
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/extensions/browser/extension_function_histogram_value.h
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/third_party/closure_compiler/externs/file_manager_private.js
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/tools/metrics/histograms/histograms.xml
[modify]
http://crrev.com/b72ec427905846d002f9dde5b3555c40d6b9d0cf/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-14 02:03:49 UTC
Permalink
Comment #28 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c28

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=191873

------------------------------------------------------------------
r191873 | ***@chromium.org | 2015-03-14T01:44:02.037156Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/WebDOMFileSystem.cpp?r1=191873&r2=191872&pathrev=191873

Enable generating File System URLs for directories.

Previously, only files were supported.

TEST=Not used yet, tested manually.
BUG=323422

Review URL: https://codereview.chromium.org/993303002
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-20 10:28:33 UTC
Permalink
Comment #29 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c29

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/26fbaa282e764f3e340332d12a7032a488e0a41a

commit 26fbaa282e764f3e340332d12a7032a488e0a41a
Author: Tomasz Mikolajewski <***@chromium.org>
Date: Fri Mar 20 09:29:08 2015

Implement chrome.fileSystem.requestFileSystem().

This CL moves the private chrome.fileManagerPrivate.requestFileSystem to the
new namespace with the following differences:
- It returns an isolated file system (instead of an external).
- It's much simplified.

It's currently enabled to component apps only. This restriction will be
released
in the upcoming CL.

TEST=Tested partially by existing browser tests.
BUG=323422
R=***@chromium.org, ***@chromium.org, ***@chromium.org,
***@chromium.org, ***@chromium.org

Review URL: https://codereview.chromium.org/985533004

Cr-Commit-Position: refs/heads/master@{#321538}

[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/chromeos/app_mode/kiosk_app_manager.h
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/browser/extensions/api/file_system/file_system_api.h
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/common/extensions/api/_permission_features.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/common/extensions/api/file_manager_private.idl
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/common/extensions/api/file_system.idl
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/renderer/resources/extensions/file_system_custom_bindings.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/app_file_handler_multi/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/app_file_handler_multi/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/content_checksum_test/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/content_checksum_test/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/drive_search_test/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/drive_search_test/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/file_watcher_test/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/file_watcher_test/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/handler_test_runner/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/handler_test_runner/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/multi_profile_copy/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_browser/multi_profile_copy/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/add_watcher/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/add_watcher/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/big_file/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/copy_entry/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/create_directory/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/create_file/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/delete_entry/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/evil/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/get_all/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/get_metadata/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/mime_type/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/mime_type/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/move_entry/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/notify/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/notify/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/read_file/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/remove_watcher/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/remove_watcher/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/test_util/test_util.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/thumbnail/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/thumbnail/test.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/truncate/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/chrome/test/data/extensions/api_test/file_system_provider/write_file/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/extensions/browser/extension_function_histogram_value.h
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/third_party/closure_compiler/externs/chrome_extensions.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/third_party/closure_compiler/externs/file_manager_private.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/tools/metrics/histograms/histograms.xml
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/audio_player/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/file_manager/background/js/volume_manager.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/file_manager/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/gallery/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/image_loader/image_loader.js
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/image_loader/manifest.json
[modify]
http://crrev.com/26fbaa282e764f3e340332d12a7032a488e0a41a/ui/file_manager/video_player/manifest.json
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-21 07:45:19 UTC
Permalink
Comment #30 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c30

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/9fc68a88795282e861df36876d20fed87129c60a

commit 9fc68a88795282e861df36876d20fed87129c60a
Author: xiyuan <***@chromium.org>
Date: Sat Mar 21 07:43:21 2015

Minor update for kiosk auto launch detection for requestFileSystem.

BUG=323422

Review URL: https://codereview.chromium.org/1020253002

Cr-Commit-Position: refs/heads/master@{#321690}

[modify]
http://crrev.com/9fc68a88795282e861df36876d20fed87129c60a/chrome/browser/extensions/api/file_system/file_system_api.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-23 05:45:51 UTC
Permalink
Updates:
Status: Fixed

Comment #31 on issue 323422 by ***@chromium.org: Grant permissions per
mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
c***@googlecode.com
2015-03-24 07:25:33 UTC
Permalink
Comment #32 on issue 323422 by ***@chromium.org: Grant permissions
per mount point in chrome.fileBrowserPrivate.requestFileSystem().
https://code.google.com/p/chromium/issues/detail?id=323422#c32

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd

commit 89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd
Author: mtomasz <***@chromium.org>
Date: Tue Mar 24 06:17:11 2015

Add a whitelist for chrome.fileSystem.requestFileSystem.

Instead of allowing all component apps, this CL whitelists only those apps
which need access to this API.

TEST=All current tests pass.
BUG=323422

Review URL: https://codereview.chromium.org/1030533002

Cr-Commit-Position: refs/heads/master@{#321942}

[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/browser/chromeos/file_manager/app_id.h
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/common/extensions/api/_permission_features.json
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/test/data/extensions/api_test/file_browser/app_file_handler_multi/manifest.json
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/test/data/extensions/api_test/file_browser/app_file_handler_multi/test.js
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/test/data/extensions/api_test/file_system_provider/thumbnail/manifest.json
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/test/data/extensions/api_test/file_system_provider/truncate/manifest.json
[modify]
http://crrev.com/89cdf95aef2c71cc6fb6cf463d0f6c93eab52cbd/chrome/test/data/extensions/api_test/file_system_provider/write_file/manifest.json
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/a/chromium.org/group/chromium-bugs

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-bugs+***@chromium.org.
Loading...