Issue 425381 in chromium: Build target 'blink_heap_unittests' depends on the whole Blink

[c***@googlecode.com]

Status: Untriaged
Owner: ----
Labels: Type-Bug Pri-3 Cr-Blink-GarbageCollection

New issue 425381 by ***@chromium.org: Build target 'blink_heap_unittests'
depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

Version: ToT
OS: All

What steps will reproduce the problem?
1. ninja -C out/Debug blink_heap_unittests

What is the expected output? What do you see instead?
Expected: Build finishes quickly because the target is just a unit test of
Source/platform/heap/.
Actual: It build everything in Blink.


Please use labels and text to provide additional information.

blink_platform_tests.gyp:

'target_name': 'blink_heap_unittests',
'type': 'executable',
'dependencies': [
'../config.gyp:unittest_config',
'../wtf/wtf.gyp:wtf',
'../wtf/wtf_tests.gyp:wtf_unittest_helpers',
'<(DEPTH)/base/base.gyp:test_support_base',
'<(DEPTH)/content/content_shell_and_tests.gyp:test_support_content',
'blink_platform.gyp:blink_platform',


content_shell_and_tests.gyp:test_support_content brings the whole content
module as well as Blink.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Status: Available
Cc: ***@chromium.org

Comment #1 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

Is this something I can help with? Is there someone available and familiar
with this code that can direct me through this change (as I'm not familiar
with all the details of this code)?

I'd be very happy to look into this.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Cc: oilpan-***@chromium.org

Comment #2 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

https://chromium.googlesource.com/chromium/blink/+/690fdfb0bb4446b9fee23a5bca98823e2076372b
introduced
the dependency.
AFAIK, we removed parallel marking/sweeping. We might be able to revert it
simply.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Owner: ***@google.com

Comment #3 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

tasak: Could you take this bug as a GYP expert?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #4 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

I want to look at this haraken.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #5 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

I will see if just reverting the cited patch works.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #6 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

I will try to work on this until the weekend.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Cc: ***@chromium.org ***@chromium.org ***@chromium.org

Comment #11 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

Issue 579470 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Owner: ***@chromium.org
Cc: ***@chromium.org

Comment #12 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

haraken@ Can you triage this? How hard is it to fix this? This is pretty
bad.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Owner: ***@chromium.org

Comment #13 on issue 425381 by ***@chromium.org: Build
target 'blink_heap_unittests' depends on the whole Blink
https://code.google.com/p/chromium/issues/detail?id=425381

keishi-san: Would you take a look at this?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings